Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 427952 - dev-util/indent keywording request
Summary: dev-util/indent keywording request
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Other
: Normal enhancement
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2012-07-24 21:53 UTC by Chí-Thanh Christopher Nguyễn
Modified: 2012-07-25 22:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chí-Thanh Christopher Nguyễn gentoo-dev 2012-07-24 21:53:38 UTC
Please keyword dev-util/indent ~amd64-fbsd as the upcoming mesa-8.1 release depends on it.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2012-07-25 02:14:53 UTC
The configure check will happily use `cat' when indent isn't found, so I doubt this new dep is really necessary.
Comment 2 Ben de Groot (RETIRED) gentoo-dev 2012-07-25 13:45:06 UTC
I've hidden indent behind !amd64-fbsd for the time being, until this is resolved one way or the other.
Comment 3 wojtek 2012-07-25 20:58:50 UTC
with
USE="classic egl gallium gles2 nptl shared-glapi xorg"
and 
VIDEO_CARDS="i965 intel"

mesa without indent dependency build fine and works too on my T61.

USE="indent" adds a lot of Perl dependencies :/
Comment 4 Richard Yao (RETIRED) gentoo-dev 2012-07-25 22:11:33 UTC
sys-freebsd/freebsd-ubin provides /usr/bin/indent. dev-util/indent is a GNU fork of the original indent, which is used in *BSD. The original indent supports all of the flags used by mesa 8.1, with the exception of -bls:

http://cgit.freedesktop.org/mesa/mesa/commit/configure.ac?id=2224fb6047dd96cbc11d7f2093319e5eb49c0b6b

In the original indent, -bl/-br determine brace placement for both statements and declarations. GNU ident redefined -bl/-br to only apply to statements. GNU indent then implemented -bls/-brs and -blf/-brf to apply to struct declarations and function declarations respectively.

The ~x86-fbsd keyword never should have been in dev-util/indent. It has been dropped from the ebuild.

Instead of keywording dev-util/indent, we could modify autotools to distinguish between GNU ident and the original indent, using appropriate options for each. A quicker way of doing this would be to just patch -brs out of the current autotools check when userland_BSD is set, but that is a hack.
Comment 5 Chí-Thanh Christopher Nguyễn gentoo-dev 2012-07-25 22:17:35 UTC
Bug 428112 was filed regarding the mesa issue. This bug can be closed as mesa will use BSD indent.