I haven't used easytag for a short while and now that I'm back at it, it seems to output invalid ID3 tags. I have reproduced this both with 2.1.6-r3 & 2.1.7-r2; dependent id3 libs have only a single version in the tree. The problem looks like that: 1. I have a .mp3 file. Both easytag and random programs read the tags correctly, 2. I edit the file with easytag. Now only easytag is able to read the tags. I have tried reading the resulting file with id3info, id3v2, mpd -- they all say that the file has no tags. 'file' says it has tags, and through hex viewer I see some data. I will investigate this further with vbindiff. -- Portage 2.2.0_alpha118_p2 (default/linux/amd64/10.0/desktop, gcc-4.7.1, glibc-2.15-r2, 3.4.0-pomiocik+ x86_64) ================================================================= System uname: Linux-3.4.0-pomiocik+-x86_64-Intel-R-_Pentium-R-_Dual_CPU_T2330_@_1.60GHz-with-gentoo-2.1 Timestamp of tree: Thu, 19 Jul 2012 05:45:01 +0000 distcc 3.1 x86_64-pc-linux-gnu [enabled] app-shells/bash: 4.2_p36 dev-java/java-config: 2.1.12 dev-lang/python: 2.6.8, 2.7.3-r2, 3.1.5, 3.2.3-r1 dev-util/cmake: 2.8.8-r3 dev-util/pkgconfig: 0.27 sys-apps/baselayout: 2.1-r1 sys-apps/openrc: 0.10.5 sys-apps/sandbox: 2.6 sys-devel/autoconf: 2.13, 2.69 sys-devel/automake: 1.9.6-r3, 1.11.6, 1.12.2 sys-devel/binutils: 2.22-r1 sys-devel/gcc: 4.7.1 sys-devel/gcc-config: 1.7.3 sys-devel/libtool: 2.4.2 sys-devel/make: 3.82-r3 sys-kernel/linux-headers: 3.4-r1 (virtual/os-headers) sys-libs/glibc: 2.15-r2 Repositories: gentoo gentoo-cvs betagarden gamerlay-stable games scarabeus science x11 sunrise mgorny Installed sets: @dep_librarian, @dep_stconnlist ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=core2 -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /lib64/systemd/system /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=core2 -O2 -pipe" DISTDIR="/usr/local/portage/distfiles" EMERGE_DEFAULT_OPTS="--ask --keep-going --quiet-build=n" FCFLAGS="-march=core2 -O2 -pipe" FEATURES="assume-digests binpkg-logs collision-protect config-protect-if-modified distcc distlocks ebuild-locks fixlafiles multilib-strict news parallel-fetch parse-eapi-ebuild-head preserve-libs protect-owned sandbox sfperms sign strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync" FFLAGS="-march=core2 -O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" INSTALL_MASK="/usr/share/locale /etc/logrotate.d" LANG="pl_PL.UTF-8" LC_ALL="pl_PL.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu" LINGUAS="" MAKEOPTS="-j6" PKGDIR="/usr/local/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --times --compress --force --whole-file --delete --stats --timeout=45 --exclude=/distfiles --exclude=/packages --exclude=/local" PORTAGE_TMPDIR="/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/var/tmp/gx86 /usr/portage/local/betagarden /usr/portage/local/gamerlay /usr/portage/local/games /usr/portage/local/scarabeus /usr/portage/local/science /usr/portage/local/x11 /usr/portage/local/sunrise /home/mgorny/git/mgorny-repo" SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage" USE="X a52 aac acl acpi alsa amd64 avahi bash-completion bluetooth branding bzip2 cairo caps cdda cdr cli cracklib crypt cups curl cxx dbus dirac djvu dri dts dvd dvdr emboss encode exif expat fam fbcon fftw filecaps firefox flac fontconfig gd gdbm gif gmp gnome-keyring gnutls gpm graphviz gtk iconv icu idn imagemagick ipv6 java6 jbig jpeg jpeg2k kate lcms libedit libnotify libproxy lzma mad matroska mmap mmx mmxext mng modules mp3 mp4 mpeg mtp mudflap multilib ncurses nptl ogg opencore-amr openexr opengl openmp pam pango pch pcre pdf png ppds pppd qt3support qt4 raw readline schroedinger sdl session smp sndfile speex spell sse sse2 sse3 ssl ssse3 startup-notification svg systemd tcpd theora threads tiff timidity truetype udev unicode upnp upower usb v4l2 vcd vim-syntax vorbis wavpack wifi wmf wxwidgets x264 xcb xcomposite xml xmpp xorg xpm xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_TARGETS="python2_6 python2_7 python3_1 python3_2" RUBY_TARGETS="ruby18 ruby19" SANE_BACKENDS="artec_eplus48u net" USERLAND="GNU" VIDEO_CARDS="fbdev radeon r300 r600 vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" USE_PYTHON="2.6 2.7 3.2" Unset: CPPFLAGS, CTARGET, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS ================================================================= Package Settings ================================================================= media-sound/easytag-2.1.7-r2 was built with the following: USE="mp3 (multilib) -flac -mp4 -speex -vorbis -wavpack"
Looking at vbindiff before and after the edit, and at the standard [1], I see the following differences: 1. The flags field has changed from 0x80 to 0x00 (AFAIU easytag removed 'unsynchronisation' bit), 2. Null-terminated strings were replaced with non-null-terminated ones, and size of the fields were decreased by 1, 3. The ID3v1 tag is removed from the end of the file (as expected). What's interesting, vim-removing the ID3v1 tag from the original file seems to make id3v2 unable to read ID3v2 as well... and mplayer sees both tags. I'm starting to think this is not actually a bug in easytag but in most tag readers instead... [1]:http://www.id3.org/id3v2.4.0-structure
I think I'm almost there. It seems that ID3V2_LATEST is set to 2.3 for some reason...
Created attachment 318620 [details, diff] Patch enabling v2.4 support I think they forgot to bump it...
Should this be added to tree?
