Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 427156 - x11-misc/redshift-1.7[-gtk] should not install icons
Summary: x11-misc/redshift-1.7[-gtk] should not install icons
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Sebastian Pipping
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-18 22:08 UTC by Maxim Kammerer
Modified: 2012-07-21 17:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Fix conditionals in Makefile.am (redshift-1.7-make-conditionals.patch,2.20 KB, patch)
2012-07-20 22:26 UTC, Sebastian Pipping 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Kammerer 2012-07-18 22:08:27 UTC 
The icons:
-rw-r--r-- 1 root root 104394 Jul 18 22:04 /usr/share/icons/hicolor/scalable/apps/redshift-status-off.svg
-rw-r--r-- 1 root root  98173 Jul 18 22:04 /usr/share/icons/hicolor/scalable/apps/redshift-status-on.svg
-rw-r--r-- 1 root root  98173 Jul 18 22:04 /usr/share/icons/hicolor/scalable/apps/redshift.svg

only make sense when gtk UI is enabled.
Comment 1 Sebastian Pipping gentoo-dev 2012-07-20 22:26:40 UTC 
Created attachment 318766 [details, diff]
Fix conditionals in Makefile.am

It seems overkill at first, but it quickly turned interesting.  As a side effect, the patch fixes a bug with "make dist" that upstream may be interested in.  Attaching a copy of the patch for the curious.


+*redshift-1.7-r1 (20 Jul 2012)
+
+  20 Jul 2012; Sebastian Pipping <sping@gentoo.org> +redshift-1.7-r1.ebuild,
+  +files/redshift-1.7-make-conditionals.patch:
+  No longer install .svg files for USE=-gtk (bug #427156)
+  The patch has been written with upstream in mind.
+
Comment 2 Maxim Kammerer 2012-07-21 17:23:01 UTC 
Installs correctly with USE="nls -geoclue -gnome -gtk", thanks!