Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 425750 - games-emulation/sdlmame-0.146_p3: version bump
Summary: games-emulation/sdlmame-0.146_p3: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Games
URL: http://mamedev.org/updates.html
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-10 22:07 UTC by Markus Rathgeb
Modified: 2013-02-12 21:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
games-emulation/sdlmame-0.146_p2 (test) (sdlmame-0.146_p2.ebuild,4.49 KB, text/plain)
2012-07-11 18:24 UTC, Markus Rathgeb
Details
games-emulation/sdlmame-0.146_p2 (sdlmame-0.146_p2.ebuild,4.69 KB, text/plain)
2012-07-11 22:10 UTC, Markus Rathgeb
Details
sdlmame-0.146_p2-makefile.patch (sdlmame-0.146_p2-makefile.patch,1.43 KB, patch)
2012-07-11 22:11 UTC, Markus Rathgeb
Details | Diff
sdlmame-0.146_p2-no-opengl.patch (sdlmame-0.146_p2-no-opengl.patch,436 bytes, text/plain)
2012-07-11 22:12 UTC, Markus Rathgeb
Details
mame0146_p2-wiimote.patch (mame0146_p2-wiimote.patch,19.65 KB, text/plain)
2012-07-11 22:12 UTC, Markus Rathgeb
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Rathgeb 2012-07-10 22:07:24 UTC
v0.144 is the most recent version in the portage tree.

Perhaps we could bump to a more recent version.

I will try to support the bump request but I have to wait for some spare time.

Reproducible: Always
Comment 1 Markus Rathgeb 2012-07-11 18:24:58 UTC
Created attachment 317938 [details]
games-emulation/sdlmame-0.146_p2 (test)

Still incomplete but working ebuild.
Patches have to be adjusted to fit for this version.
Comment 2 Markus Rathgeb 2012-07-11 22:10:34 UTC
Created attachment 317954 [details]
games-emulation/sdlmame-0.146_p2
Comment 3 Markus Rathgeb 2012-07-11 22:11:42 UTC
Created attachment 317956 [details, diff]
sdlmame-0.146_p2-makefile.patch
Comment 4 Markus Rathgeb 2012-07-11 22:12:01 UTC
Created attachment 317958 [details]
sdlmame-0.146_p2-no-opengl.patch
Comment 5 Markus Rathgeb 2012-07-11 22:12:17 UTC
Created attachment 317960 [details]
mame0146_p2-wiimote.patch
Comment 6 Markus Rathgeb 2012-07-15 15:29:34 UTC
15 Jul 2012: MAME 0.146u3 was released
Comment 7 Markus Rathgeb 2012-07-15 17:16:07 UTC
I will commit the ebuild for future version to my overlay until they are integrated in the official tree.
The Ebuild and patches for 0.146u3 could be found here:
https://github.com/maggu2810/maggu2810-overlay/tree/master/games-emulation/sdlmame
Comment 8 Julian Ospald 2012-07-15 19:37:42 UTC
build output is not verbose

CFLAGS, AR, CC, LD are still ignored
use toolchain-funcs with tc-export CC or tc-getCC in conjunction with "CC ?= gcc" and "CFLAGS ?= -O3" for example which will only set those vars if they are not in the env and not passed to make. For crucial compiler flags we can do/leave CFLAGS += ...

rewriting makefile and adding/changing options, so you can pass them to emake would be much cleaner instead of doing these sed-functions (and you can send it upstream). Some options should already work like "BUILD_ZLIB" (but "BIGENDIAN" is used in conjunction with "ifndef" which would need to be changed to ifeq...). You could then use something like:
buildit() { use $1 && echo 1 || echo 0 ; }
emake BUILD_ZLIB=$(buildit zlib)

virtual/pkgconfig missing from DEPEND

why not use EAPI=4?

I would preset opengl in ${MY_CONF_PN}.ini if the useflag is activated.
Comment 9 Markus Rathgeb 2012-07-15 19:54:58 UTC
I am using the "official" ebuild (that one in the portage tree) as a template.
So I changed only what is necessary because that one is already in tree and so accepted.
I could also try to write the ebuild from scratch, but I thought it should be okay if the previous one was accepted.
Comment 10 Julian Ospald 2013-02-12 21:58:07 UTC
+*sdlmame-0.148_p1 (12 Feb 2013)
+
+  12 Feb 2013; Julian Ospald <hasufell@gentoo.org> +sdlmame-0.148_p1.ebuild,
+  +files/sdlmame-0.148_p1-makefile.patch,
+  +files/sdlmame-0.148_p1-no-opengl.patch:
+  version bump wrt #425750