There are two problems with the current ebuild: 1. It does not list xmlto as build-time dependency but uses it to generate manpages 2. With installed xmlto, compilation still fails due to the following error: xmlto: Fix document syntax or use --skip-validation option I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd /var/tmp/portage/dev-db/pgbouncer-1.5.2/work/pgbouncer-1.5.2/doc/usage.xml:2: warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd" D DocBook XML V4.5//EN" "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd" Reproducible: Always
The second is simply one other dep: app-text/docbook-xml-dtd:4.5.
TBH, I see no point in generating the documentation at all. We have .txt's and man pages. What's the benefit of adding .html to the mix? It seems that the xmlto req is hidden behind a asciidoc one which is why I never saw this until now. I'd rather just skip entering doc/ in Makefile. Thoughts?
(In reply to comment #2) > TBH, I see no point in generating the documentation at all. We have .txt's > and man pages. What's the benefit of adding .html to the mix? > > It seems that the xmlto req is hidden behind a asciidoc one which is why I > never saw this until now. I'd rather just skip entering doc/ in Makefile. > Thoughts? HTML pages are prettier, and another user wants it. Looks like we really only need to add the dependencies.
*** Bug 444048 has been marked as a duplicate of this bug. ***
Created attachment 334124 [details] pgbouncer-1.5.3-r1.ebuild This ebuild adds these dependencies (as well as asciidoc). It also fixes a couple of things: - /{var/}run consistency throughout - proper sed:ing of config. Upstream added paths for 1.5.3 - add logrotate script - new init script for bug #410647 and bug #410645. I'm terribly sorry for the delay. Hopefully we should be all set now. I'd still like to hide the asciidoc/xmlto/etc assumption behind USE=doc, but it feels like upstream (it's pretty easy to hack tho).
Created attachment 334126 [details] pgbouncer.initd
Created attachment 334128 [details] logrotate
Created attachment 334130 [details] pgbouncer.initdd spaces to tabs in two places
Created attachment 334132 [details] logrotate add -q to opts so we don't get output from logrotate
Created attachment 335536 [details] pgbouncer.initd Updated init script that uses checkpath over mkdir
+ 14 Jan 2013; Sergey Popov <pinkbyte@gentoo.org> files/pgbouncer.initd: + Update initscript, fix bugs #410645 and #410647, thanks to Johan Bergström + 14 Jan 2013; Sergey Popov <pinkbyte@gentoo.org> +pgbouncer-1.5.3-r1.ebuild: + Revision bump for reflect latest change
Comment on attachment 335536 [details] pgbouncer.initd For now, i have commited initscript only, to fix two other bugs - #410645 and #410647
*pgbouncer-1.5.4 (19 Jul 2013) 19 Jul 2013; Aaron W. Swenson <titanofold@gentoo.org> -pgbouncer-1.4.2.ebuild, -pgbouncer-1.5.ebuild, -pgbouncer-1.5.1.ebuild, -pgbouncer-1.5.2.ebuild, -pgbouncer-1.5.3.ebuild, -pgbouncer-1.5.3-r1.ebuild, +pgbouncer-1.5.4.ebuild, +files/logrotate, +files/pgbouncer.confd, +files/pgbouncer-dirs.patch, files/pgbouncer.initd, metadata.xml: Clean out old and insecure versions. Version bump. Fixes bugs 425480, 460310, 477062, and 425034.
