424822 – net-misc/axel - sed script fails when LDFLAGS contains a slash (/)

Bug 424822 - net-misc/axel - sed script fails when LDFLAGS contains a slash (/)

Summary: net-misc/axel - sed script fails when LDFLAGS contains a slash (/)

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Justin Lecher (RETIRED)

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2012-07-05 02:48 UTC by Kevin
Modified:	2012-07-06 15:13 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch to fix delimiter problem (axel-2,4-r1-sed.patch,150 bytes, patch) 2012-07-05 02:48 UTC, Kevin	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kevin 2012-07-05 02:48:38 UTC

Created attachment 317198 [details, diff]
patch to fix delimiter problem

as part of source prepare sed calls to replace LFLAGS with LDFLAGS
howerver sed fails when LDFLAGS is set to any expression with a / since / is the delimiter. This causes the expression to terminate early and complain about invalid options to s in expressing -e.
attached is a diff-patch to an ebuild that works by using | instead of /.
this is a problem in both 2.3 and 2.4-r1

Comment 1 Jeroen Roovers (RETIRED) gentoo-dev

2012-07-06 14:25:39 UTC

That's a reverse patch, right?

Comment 2 Justin Lecher (RETIRED) gentoo-dev

2012-07-06 14:32:56 UTC

please add your emerge --info axel

Comment 3 Justin Lecher (RETIRED) gentoo-dev

2012-07-06 15:13:56 UTC

+*axel-2.4-r2 (06 Jul 2012)
+
+  06 Jul 2012; Justin Lecher <jlec@gentoo.org> +axel-2.4-r2.ebuild,
+  +files/axel-2.4-bffr-overflow.patch, +files/axel-2.4-buildsystem.patch:
+  Move to EAPI=4, fix buildsystem, #424822, fix potential buffer overflow
+