Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 424785 - app-office/grisbi-0.8.9 ofx file import broken
Summary: app-office/grisbi-0.8.9 ofx file import broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rémi Cardona (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-04 17:02 UTC by Derk W te Bokkel
Modified: 2012-07-08 15:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Derk W te Bokkel 2012-07-04 17:02:59 UTC
latest update of grisbi version 0.8.9 compiled with USE="ofx"  
does not import ofx files properly .. previous version 0.8.8 works with same libofx .. a regresssion has entered the code ..

please mask girsbi-0.8.9 until fixed upstream


emerge --info
Portage 2.1.11.3 (default/linux/amd64/10.0, gcc-4.6.3, glibc-2.15-r2, 3.4.4-gentoo x86_64)
=================================================================
System uname: Linux-3.4.4-gentoo-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T5870_@_2.00GHz-with-gentoo-2.1
Timestamp of tree: Mon, 02 Jul 2012 13:05:02 +0000
app-shells/bash:          4.2_p29
dev-java/java-config:     2.1.12
dev-lang/python:          2.7.3-r2, 3.2.3-r1
dev-util/cmake:           2.8.8-r3
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.10.3
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.5, 1.12.1
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.3-r2, 4.6.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.4 (virtual/os-headers)
sys-libs/glibc:           2.15-r2
Repositories: gentoo derk-personal
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--autounmask --autounmask-write --quiet-build=y"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles news parallel-fetch parse-eapi-ebuild-head protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en_GB en_US"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/home/derk/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acl alsa amd64 apng archive avcodec avformat berkdb bzip2 cairo cdda cddb cdr cifs cli cracklib crypt cups cxx dbus dri dvd dvdr encode flac fortran fuse gallium gdbm gnutls gphoto2 gpm gstreamer gtk iconv id3tag ipv6 jpeg jpeg2k lame lcms libnotify live mad mmx modules mp3 mpeg mudflap multilib ncurses nls nptl ntp ogg opengl openmp pam pcre pdf pm-utils png policykit ppds pppd qt4 readline samba scanner session sna sse sse2 ssl startup-notification svg tcl tcpd theora tiff tk twolame unicode v4l vorbis vpx wav webm wma wma-fixed x264 xcb xinerama xorg zlib" ALSA_CARDS="hda-intel intel8x0 intel8x0m" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="*" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev synaptics wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_GB en_US" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="intel vesa fbdev" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Derk W te Bokkel 2012-07-04 17:23:40 UTC
reported upstream as bug 00001502
Comment 2 Pacho Ramos gentoo-dev 2012-07-06 19:00:19 UTC
(In reply to comment #1)
> reported upstream as bug 00001502

Please provide full link as I cannot connect to their bug tracker now
Comment 3 Derk W te Bokkel 2012-07-06 19:30:56 UTC
http://www.grisbi.org/bugsreports/view.php?id=1502

yeah database is currently down .. just tried .. this is from my history ..
Comment 4 Guillaume Castagnino 2012-07-06 19:40:13 UTC
I just browsed the git history, there is absolutely no changes about the OFX import between 0.8.8 and 0.8.9 (I cannot test, I have no OFX files).
1) Have you rebuild grisbi after upgrading libofx to 0.9.5 (this is a very recent upgrade) ?
2) Have you tried to downgrade to libofx 0.9.4 (and rebuild grisbi after that) ?
Comment 5 Derk W te Bokkel 2012-07-06 20:59:25 UTC
well something is odd .. 

when using grisbi-0.8.9 compiled against libofx-0.9.5 or libofx-0.9.4 we get .. once the file is selected in the import menu  and we select forward .. we bounce to step 4/4 with the following .. 

Error !

No file has been imported, please double check that they are valid files.  Please make sure that they are not compressed and that their format is valid.


.. instead of to step 4/6


same input files work fine in grisbi-0.8.8 compiled against libofx-0.9.5 or libofx-0.9.4
 

ofx files are from two different banks: bmo, rbc  

I've used gnucash to import these files as well no issues .. with libofx-0.9.5 and libofx-0.9.4

has something in the file selection or other preprocessing changed? or has the file signiture checking changed somehow?
Comment 6 Derk W te Bokkel 2012-07-06 22:08:48 UTC
tried later unstable code base grisbi-0.9.5 error still exists .. import fails ..

so the problem was introduced into the code base in version 0.8.9 and has not been fixed so far  .. it is outside of the import.c code .. but maybe in functions or structures it references .. 

any idea how to do a diff between the two trees to see what changed?

also most of the code uses french  variable names .. which is difficult for me to make sense of completely
Comment 7 Rémi Cardona (RETIRED) gentoo-dev 2012-07-07 00:12:16 UTC
(In reply to comment #6)
> tried later unstable code base grisbi-0.9.5 error still exists .. import
> fails ..
> 
> so the problem was introduced into the code base in version 0.8.9 and has
> not been fixed so far  .. it is outside of the import.c code .. but maybe in
> functions or structures it references .. 
> 
> any idea how to do a diff between the two trees to see what changed?

I need to take a closer look at this issue, though I'll just state here for the record that I don't use nor trust OFX files coming out of financial institutions (I do everything manually).

> also most of the code uses french  variable names .. which is difficult for
> me to make sense of completely

Being French, I have a hard time understanding the code. Believe you me, the comments hardly make any sense...

Cheers
Comment 8 Rémi Cardona (RETIRED) gentoo-dev 2012-07-08 14:39:26 UTC
(In reply to comment #6)
> tried later unstable code base grisbi-0.9.5 error still exists .. import
> fails ..

Confirming. A change was made but only on the 0.8.x branch.

> so the problem was introduced into the code base in version 0.8.9 and has
> not been fixed so far  .. it is outside of the import.c code .. but maybe in
> functions or structures it references .. 

It has indeed been fixed, but in the yet-unreleased 0.8.10.

> any idea how to do a diff between the two trees to see what changed?

The diff between 0.8 and 0.9 is huge and I wouldn't bother doing it :) The diff between 0.8.8 and 0.8.9 was much smaller and I found the issue...

  git diff <treeish1>..<treeish2> -- configure.in

where "treeish" can be tags, branch names or commit hash numbers, will tell you what happened on a specific file or directory (configure.in in this case) between the 2 points in history.

As I've never made upstream Grisbi releases myself, I can't release 0.8.10 to fix it for everyone, but I can at least try to fix it in Gentoo.

Thanks
Comment 9 Rémi Cardona (RETIRED) gentoo-dev 2012-07-08 15:26:59 UTC
Should be fixed in 0.8.9-r1. Please don't hesitate to reopen this bug if you have any issues.

Thanks