Created attachment 316481 [details] proposed ebuild for 4.8.0 Rodent 4.8.0 is now online. Attached you will find a proposed ebuild for this version bump. I have added the following USE keys: experimental, core and gtk2. With these keys user may choose to enable experimental plugins (obexfs, curlftpfs, ecryptfs, cifs and samba), core dumps and use of deprecated gtk2 library instead of default gtk3.
Comment on attachment 316481 [details] proposed ebuild for 4.8.0 --- rodent-4.7.4.ebuild 2012-05-07 14:02:31.000000000 +0200 +++ - 2012-06-28 03:19:08.010470582 +0200 @@ -1,6 +1,6 @@ # Copyright 1999-2012 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 -# $Header: /var/cvsroot/gentoo-x86/x11-misc/rodent/rodent-4.7.4.ebuild,v 1.2 2012/05/05 04:53:43 jdhore Exp $ +# $Header: /var/cvsroot/gentoo-x86/x11-misc/rodent/rodent-4.8.0.ebuild,v 1.2 2012/05/05 04:53:43 jdhore Exp $ EAPI=4 inherit xfconf @@ -12,7 +12,7 @@ LICENSE="GPL-3" SLOT="0" KEYWORDS="~amd64 ~x86" -IUSE="" +IUSE="experimental core gtk2" COMMON_DEPEND=">=dev-libs/glib-2.20.5 dev-libs/libxml2 @@ -29,6 +29,25 @@ dev-util/intltool virtual/pkgconfig" +src_configure() { + local myconf + + use experimental \ + && myconf+=" --enable-experimental" \ + || myconf+=" --disable-experimental" + + use core \ + && myconf+=" --with-core" \ + || myconf+=" --with-core=no" + + use gtk2 \ + && myconf+=" --with-gtk2" \ + || myconf+=" --with-gtk2=no" + + econf \ + ${myconf} +} + pkg_setup() { DOCS=( ChangeLog README TODO ) }
Why is it possible to disable core dumps? What advantage does that bring? Also, please update the dependencies, the ebuild currently unconditionally depends on gtk2, but you said it uses gtk3. Also, drop the whole conditional gtk2 stuff - if gtk3 is the default and gtk2 is deprecated just hard-depend on gtk3 (see recent gentoo-dev discussion). Thank you.
Created attachment 316555 [details] depend on gtk3 Actually the option is to enable core dumps, not disable them. If I do not explicitly enable core dumps, then gcc does not enable them. The usual Linux configuration avoids core dumps. I always enable core dumps for obvious reasons. If you believe core dumps should be enabled by default, that is no problem with me. You are correct on the gtk2 issue. I'm just not too well versed in ebuilds. Find a corrected attachment as suggested.
I think you attached the same ebuild again. Anyway, I've bumped it to 4.8.0.
