Bug 423869 – dev-php/pecl-crack: request for php 5.4 support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Hanno Böck 2012-06-27 19:33:15 UTC]

pecl-crack doesn't support php 5.4 yet. Upstream's svn has a patch:
http://svn.php.net/viewvc/pecl/crack/trunk/crack.c?r1=297236&r2=326013&pathrev=326013

Though no new release yet. I'd propose adding a patched pecl-crack ebuild with php 5.4 support.

[Comment 1 Ole Markus With (RETIRED) 2012-08-01 11:22:13 UTC]

Even with that patch, compilation for 5.4 fails for me. Did you make it work?

[Comment 2 Hanno Böck 2012-08-18 11:09:04 UTC]

Seems we need this patch as well:
http://svn.php.net/viewvc/pecl/crack/trunk/crack.c?r1=262854&r2=297236&pathrev=326013

I've combined the two patches and will attach.

[Comment 3 Hanno Böck 2012-08-18 11:10:47 UTC]

Created attachment 321618 [details, diff]
combined patch for php 5.4 support in pecl-crack

[Comment 4 Hanno Böck 2012-08-18 11:12:04 UTC]

Or we could just let viewvc produce the combined patch :-)
http://svn.php.net/viewvc/pecl/crack/trunk/crack.c?r1=262854&r2=326013

[Comment 5 Ole Markus With (RETIRED) 2012-08-19 08:40:43 UTC]

(In reply to comment #4)
> Or we could just let viewvc produce the combined patch :-)
> http://svn.php.net/viewvc/pecl/crack/trunk/crack.c?r1=262854&r2=326013

Thanks a lot. This seems to work well. Revbump committed to CVS.