Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 423707 - app-portage/euses-2.5.7 requires /etc/make.conf to find PORTDIR
Summary: app-portage/euses-2.5.7 requires /etc/make.conf to find PORTDIR
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 429532
  Show dependency tree
 
Reported: 2012-06-26 20:03 UTC by Martin von Gagern
Modified: 2012-08-02 17:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Check if files exist before sourcing them (euses-2.5.8-make.conf.patch,556 bytes, patch)
2012-06-30 17:28 UTC, Jeroen Roovers (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2012-06-26 20:03:22 UTC
I've recently renamed my /etc/make.conf to /etc/portage/make.conf as that seemed to me the more appropriate location of the file. Now euses fails for me:

# euses ssl
sh: /etc/make.conf: No such file or directory
PORTDIR not found

It would be nice to have this fixed.

Unfortunately the code simply sources a number of files into a shell opened via popen, so adding more possible locations will result in error messages for each of those which doesn't exist. One solution would be adding file existance checks to the shell code, but that feels kind of wrong for a C application.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2012-06-30 15:43:51 UTC
Well, make.conf(5) clearly states two locations for the file (since when?) so I guess adding the second one in the shell code wouldn't harm. Also, I could redirect the output to /dev/null or similar (but I am not aware how portable that is).
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2012-06-30 17:28:56 UTC
Created attachment 316793 [details, diff]
Check if files exist before sourcing them

Would this do?
Comment 3 Martin von Gagern 2012-07-01 14:04:13 UTC
(In reply to comment #2)
> Created attachment 316793 [details, diff] [details, diff]
> Check if files exist before sourcing them
> 
> Would this do?

Works for me.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2012-07-02 03:26:55 UTC
Thank you for reporting and testing. This bug is fixed in 2.5.8.