423657 – vdr-plugin-2.eclass illegally sets empty EAPI to EAPI=4

Bug 423657 - vdr-plugin-2.eclass illegally sets empty EAPI to EAPI=4

Summary: vdr-plugin-2.eclass illegally sets empty EAPI to EAPI=4

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Television related Applications in Gentoo's Portage

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-06-26 14:27 UTC by Ian Stakenvicius (RETIRED)
Modified:	2012-06-27 19:01 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ian Stakenvicius (RETIRED) gentoo-dev

2012-06-26 14:27:42 UTC

The eclass countains, on or around line 48:

if ! has "${EAPI:-4}" 4; then
        die "API of vdr-plugin-2.eclass in EAPI=\"${EAPI}\" not established"
fi


This breaks EAPI policy, in that an empty EAPI is always assumed to be EAPI=0.  Also, eclasses cannot set a default EAPI for ebuilds since then the EAPI on-or-before-line-5 is invalid.

Comment 1 Joerg Bornkessel (RETIRED) gentoo-dev

2012-06-27 18:59:15 UTC

i changed the part to ->

case ${EAPI:-0} in
    4) ;;
    *) die "EAPI ${EAPI} unsupported."
esac

hope its well now,

anyway, all plugins converted from vdr-plugin.eclass to vdr-plugin-2.eclass have to use the (minimal) EAPI="4" !

Comment 2 Joerg Bornkessel (RETIRED) gentoo-dev

2012-06-27 19:01:24 UTC

thanks for reporting this and reviewing after i did announced this to gentoo-dev ML ;)