Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 423605 - dev-vcs/git: install OS X keychain credential helper
Summary: dev-vcs/git: install OS X keychain credential helper
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: x86 OS X
: Normal normal
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-26 09:32 UTC by Qiangning Hong
Modified: 2012-08-23 05:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to git-1.7.10.2.ebuild to install osxkeychain credential helper (git-credential-osxkeychain.patch,920 bytes, patch)
2012-06-26 09:36 UTC, Qiangning Hong
Details | Diff
patch to git-1.7.10.2.ebuild to install osxkeychain credential helper (git-credential-osxkeychain.patch,919 bytes, patch)
2012-06-27 02:07 UTC, Qiangning Hong
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Qiangning Hong 2012-06-26 09:32:50 UTC
Starting from version 1.7.9, git can cache credentials used when accessing remotes over HTTP; this helper provides integration with the OS X keychain.

I copied git-1.7.10.2.ebuild from the portage and make a patch to install git-credential-osxkeychain if $ARCH ends with "-macos".

Reproducible: Always
Comment 1 Qiangning Hong 2012-06-26 09:36:03 UTC
Created attachment 316295 [details, diff]
patch to git-1.7.10.2.ebuild to install osxkeychain credential helper

You can also check this patch on github: https://github.com/hongqn/hongqn-gentoo-overlay/commit/d3ceabd972a4b17ca6ce13e9fa3777d8eea1af53
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-06-26 13:19:37 UTC
Seems like an acceptable idea to me, assigning to maintainer
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-06-26 16:16:58 UTC
(In reply to comment #2)
> Seems like an acceptable idea to me, assigning to maintainer

After further review, you should be checking for CHOST instead of ARCH.

if [[ ${CHOST} == *-darwin* ]]; then
    foo
fi
Comment 4 Qiangning Hong 2012-06-27 02:07:32 UTC
Created attachment 316373 [details, diff]
patch to git-1.7.10.2.ebuild to install osxkeychain credential helper

Use $CHOST instead of $ARCH to identify the OS.

Thank darkside for the review.
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2012-08-23 05:38:59 UTC
Fixed in 1.7.12-r2.