Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 423413 - games-rpg/mana-0.6.1 version bump
Summary: games-rpg/mana-0.6.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-24 22:47 UTC by Nicklas Karlsson
Modified: 2012-07-13 14:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mana-0.6.1.ebuild.diff (mana-0.6.1.ebuild.diff,1.12 KB, patch)
2012-06-25 20:56 UTC, Julian Ospald
Details | Diff
mana-0.6.1-gentoo.patch (mana-0.6.1-gentoo.patch,1.43 KB, patch)
2012-06-25 20:56 UTC, Julian Ospald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nicklas Karlsson 2012-06-24 22:47:41 UTC
mana client has been released in version 0.6.1, http://manasource.org/
Comment 1 Julian Ospald 2012-06-25 09:47:00 UTC
Only change to the build system seems to be:
OPTION(ENABLE_CPP0X "Enable use of C++0x features" ON)

on top of that I discovered a few issues:
- media-libs/libpng is not slotted (mana needs :0 cause it also needs the headers)
- cmake-utils_src_compile is not carried out resulting in ignored cmake variables like verbose build output which is default now
- the build output shows that CXXFLAGS are completely ignored (change src/CmakeLists.txt line 15 to SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall") or remove it)
- no useflag for OPTION(ENABLE_MANASERV "Enable Manaserv support" OFF) ...is that intended?
Comment 2 Julian Ospald 2012-06-25 20:56:25 UTC
Created attachment 316249 [details, diff]
mana-0.6.1.ebuild.diff
Comment 3 Julian Ospald 2012-06-25 20:56:36 UTC
Created attachment 316251 [details, diff]
mana-0.6.1-gentoo.patch
Comment 4 Julian Ospald 2012-06-30 20:57:50 UTC
+*mana-0.6.1 (30 Jun 2012)
+
+  30 Jun 2012; Julian Ospald <hasufell@gentoo.org> +mana-0.6.1.ebuild,
+  +files/mana-0.6.1-gentoo.patch:
+  version bump wrt bug #423413
Comment 5 Ben Longbons 2012-07-05 17:30:32 UTC
(In reply to comment #1)
> - no useflag for OPTION(ENABLE_MANASERV "Enable Manaserv support" OFF) ...is
> that intended?

Hi,

Note that the ManaServ protocol is not yet stable - you have to use a git build of the server from the same time as the client - nor is it feature-complete.

The plan is that ManaServ will be stable when we call a release "1.0". Confusingly, there are a couple of builds called v1.0.0-beta{,2} that are *older* than 0.5

Also, "server" is a pretty bad name for the flag; it sounds like it actually compiles the server (which, when it comes time, should be a separate package rather than a use flag.)
Comment 6 Julian Ospald 2012-07-05 18:00:12 UTC
(In reply to comment #5)
> (In reply to comment #1)
> > - no useflag for OPTION(ENABLE_MANASERV "Enable Manaserv support" OFF) ...is
> > that intended?
> 
> Hi,
> 
> Note that the ManaServ protocol is not yet stable - you have to use a git
> build of the server from the same time as the client - nor is it
> feature-complete.
> 
> The plan is that ManaServ will be stable when we call a release "1.0".
> Confusingly, there are a couple of builds called v1.0.0-beta{,2} that are
> *older* than 0.5

Do you suggest to remove support completely?

> 
> Also, "server" is a pretty bad name for the flag; it sounds like it actually
> compiles the server (which, when it comes time, should be a separate package
> rather than a use flag.)

There is a description of that useflag in metadata.xml, do you think that is not enough?
Comment 7 Ben Longbons 2012-07-12 20:41:08 UTC
<grumble about not *automatically* being added to CC list>

(In reply to comment #6)
> Do you suggest to remove support completely?
Yes, for now. If anyone wants ManaServ support, they should follow git; I do have a live ebuild in my overlay [1], though it hasn't been updated since before 0.6 so it will need some work.

However, since anyone using manaserv will likely need to compile the server from  git anyway, and the server is not ready for packaging (I assume it's against policy to have only live ebuilds for a package?), a live client ebuild is of limited use.

If you're curious about the suitability of snapshot builds of manaserv, I suggest asking on Freenode #mana - that's not my area of development - but is there enough demand for it?

> There is a description of that useflag in metadata.xml, do you think that is
> not enough?
The description itself adequate for the long turn, but if you do leave it at this time, I strongly suggest adding an (EXPERIMENTAL) or (UNSTABLE) for now. And I *would* recommend calling the flag "manaserv" in any case.

The cmake option name is not likely to change, so you could leave it commented out in the ebuild.

Once ManaServ support becomes stable, it will be the cmake default (it is when building from git anyways, it just gets turned off for releases).
Even when that time comes, it would be reasonable to have it as a use flag (due to increased dependencies, compile time, etc) that is + in IUSE.


[1] https://github.com/o11c/ebuilds/blob/master/games-rpg/mana/mana-9999.ebuild

tl;dr: ManaServ should not be enabled just as a curiosity. Is there anyone who cares much about it yet?
Comment 8 Julian Ospald 2012-07-13 14:00:58 UTC
had a talk with Ablu and he basically said something similar

We probably will wait for the first manaserv release before we support it in the client too.


+  13 Jul 2012; Julian Ospald <hasufell@gentoo.org> mana-0.6.1.ebuild,
+  metadata.xml:
+  drop server useflag cause MANASERV feature is alpha and not supported yet
+