Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 423327 - games-rpg/eternal-lands bundles minizip
Summary: games-rpg/eternal-lands bundles minizip
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Richard Freeman
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-24 15:12 UTC by Richard Freeman
Modified: 2012-12-02 23:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
eternal-lands-1.9.3-r2.ebuild.diff (eternal-lands-1.9.3-r2.ebuild.diff,418 bytes, patch)
2012-06-24 17:00 UTC, Julian Ospald
Details | Diff
eternal-lands-1.9.3-minizip.patch (eternal-lands-1.9.3-minizip.patch,2.09 KB, patch)
2012-06-24 17:00 UTC, Julian Ospald
Details | Diff
eternal-lands-1.9.3-r2.ebuild.diff (eternal-lands-1.9.3-r2.ebuild.diff,864 bytes, patch)
2012-06-24 17:52 UTC, Julian Ospald
Details | Diff
eternal-lands-1.9.3-r2.ebuild.diff (eternal-lands-1.9.3-r2.ebuild.diff,1.61 KB, patch)
2012-06-24 18:05 UTC, Julian Ospald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Freeman gentoo-dev 2012-06-24 15:12:33 UTC
Patch to use system zlib[minizip].
Comment 1 Julian Ospald 2012-06-24 17:00:09 UTC
Created attachment 316167 [details, diff]
eternal-lands-1.9.3-r2.ebuild.diff

ebuild diff
Comment 2 Julian Ospald 2012-06-24 17:00:12 UTC
Created attachment 316169 [details, diff]
eternal-lands-1.9.3-minizip.patch

I guess we would need to test the update thingy since it seems to make use of minizip shit.
Comment 3 Julian Ospald 2012-06-24 17:01:20 UTC
oh, and the package is obviously missing virtual/pkgconfig...
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-06-24 17:14:49 UTC
The patch looks good to me
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2012-06-24 17:48:42 UTC
The ebuild patch should also remove the `sed` line that adds the OF change when this gets committed
Comment 6 Julian Ospald 2012-06-24 17:52:44 UTC
Created attachment 316173 [details, diff]
eternal-lands-1.9.3-r2.ebuild.diff

right, fixed that, added pkgconfig, fixed the usex line
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2012-06-24 17:58:38 UTC
and the actual sys-libs/zlib[minizip] dep? :)
Comment 8 Julian Ospald 2012-06-24 18:05:39 UTC
Created attachment 316175 [details, diff]
eternal-lands-1.9.3-r2.ebuild.diff

(In reply to comment #7)
> and the actual sys-libs/zlib[minizip] dep? :)

done that, reordered deps alphabetically and slotted libpng.
Comment 9 Richard Freeman gentoo-dev 2012-12-02 23:21:24 UTC
Thanks for the patches - fixed today with the build error.