Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 423323 - python-distutils-ng.eclass should not ignore EPREFIX
Summary: python-distutils-ng.eclass should not ignore EPREFIX
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All All
: Highest blocker (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-24 15:06 UTC by MATSUI Tetsushi
Modified: 2012-10-30 17:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff against eclass (python-distutils-ng.eclass.diff,460 bytes, text/plain)
2012-06-24 15:06 UTC, MATSUI Tetsushi
Details
Updated patch (0001-Fix-EPREFIX-support.patch,1.25 KB, patch)
2012-10-29 14:48 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description MATSUI Tetsushi 2012-06-24 15:06:04 UTC
Created attachment 316155 [details]
diff against eclass

python-distutils-ng.eclass ignore EPREFIX in function _python-distutils-ng_get_binary_for_implementation.
It causes an emerge failure of net-mail/getmail for me:

>>> Preparing source in /Users/tetsushi/Gentoo/var/tmp/portage/net-mail/getmail-4.30.1/work/getmail-4.30.1 ...
/Users/tetsushi/Gentoo/var/tmp/portage/net-mail/getmail-4.30.1/temp/environment: line 331: /usr/bin/python2.7: No such file or directory

The attached patch can fix this, which just prefixes hard coded /usr/bin with ${EPREFIX}.
Comment 1 Fabian Groffen gentoo-dev 2012-10-29 14:08:27 UTC
This is really breaking each and every package that uses this eclass for Prefix (like javatoolkit).

Python team, please advise.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-10-29 14:34:46 UTC
(In reply to comment #1)
> This is really breaking each and every package that uses this eclass for
> Prefix (like javatoolkit).
> 
> Python team, please advise.

I can fix it if really desired, or just let the eclass stay deprecated and migrate the relevant packages to python-r1/distutils-r1 if maintainers don't mind.
Comment 3 Fabian Groffen gentoo-dev 2012-10-29 14:38:18 UTC
it is breaking now, so any solution that unbreaks is fine, whatever you prefer
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-10-29 14:48:34 UTC
Created attachment 327686 [details, diff]
Updated patch

Could you please test this patch? It should additionally fix 'redoing' Python scripts.
Comment 5 Fabian Groffen gentoo-dev 2012-10-30 10:46:17 UTC
the patch seems to allow me to install javatoolkit, and also to emerge packages that perform rewrites.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-10-30 17:22:48 UTC
/var/cvsroot/gentoo-x86/eclass/ChangeLog,v  <--  ChangeLog
new revision: 1.485; previous revision: 1.484
/var/cvsroot/gentoo-x86/eclass/python-distutils-ng.eclass,v  <--  python-distutils-ng.eclass
new revision: 1.29; previous revision: 1.28
Comment 7 Fabian Groffen gentoo-dev 2012-10-30 17:27:14 UTC
thanks!