Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 423319 - games-rpg/eternal-lands several build issues
Summary: games-rpg/eternal-lands several build issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Richard Freeman
URL:
Whiteboard:
Keywords: PATCH
: 369315 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-06-24 13:52 UTC by Julian Ospald
Modified: 2016-08-27 14:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
eternal-lands-1.9.3-build.patch (eternal-lands-1.9.3-build.patch,15.84 KB, patch)
2012-06-24 13:52 UTC, Julian Ospald
Details | Diff
eternal-lands-1.9.3-r2.ebuild.diff (eternal-lands-1.9.3-r2.ebuild.diff,4.32 KB, patch)
2012-06-24 13:54 UTC, Julian Ospald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2012-06-24 13:52:45 UTC
Created attachment 316149 [details, diff]
eternal-lands-1.9.3-build.patch

1. build fails if underlinking is not permitted like for the gold linker
2. build is not verbose
3. LDFLAGS are ignored/overwritten
4. CC/CXX are ignored/overwritten

and some other stuff

I removed some seds, simplified a few things. This patch only works with the altered ebuild. attaching...
Comment 1 Julian Ospald 2012-06-24 13:54:15 UTC
Created attachment 316151 [details, diff]
eternal-lands-1.9.3-r2.ebuild.diff

also bumped to EAPI=4
Comment 2 Richard Freeman gentoo-dev 2012-06-24 14:57:21 UTC
Ok, works fine in my testing.  Short of committing this I doubt we'll be able to get testing on odd archs/etc.  

I'm going to commit and keep an eye out for any issues.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2012-06-24 14:59:48 UTC
+		DEBUG="$(usex debug "yes" "no")" \
+		BSD_KERNEL="$(usex kernel_linux "no" "yes")" \

to

+		DEBUG="$(usex debug)" \
+		BSD_KERNEL="$(usex kernel_linux)" \

since it has default values of yes/no in eutils.eclass
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-06-24 15:01:02 UTC
	# Fix for Gentoo zlib OF redefine
	sed -i '1i#define OF(x) x' `find -name "*.c"` || die "sed failed"

looks suspicious. internal copy of sys-libs/zlib[minizip]? should propably be patched to use the system copy instead of working it around like this.
Comment 5 Richard Freeman gentoo-dev 2012-06-24 15:10:59 UTC
(In reply to comment #4)
> 	# Fix for Gentoo zlib OF redefine
> 	sed -i '1i#define OF(x) x' `find -name "*.c"` || die "sed failed"
> 
> looks suspicious. internal copy of sys-libs/zlib[minizip]? should propably
> be patched to use the system copy instead of working it around like this.

Interesting.  Hadn't realized it actually bundled something.  It is using the system zlib headers, and zlib itself, just not minizip.

I'll log that as a new bug.
Comment 6 Julian Ospald 2012-06-24 15:19:56 UTC
(In reply to comment #3)
> +		DEBUG="$(usex debug "yes" "no")" \
> +		BSD_KERNEL="$(usex kernel_linux "no" "yes")" \
> 
> to
> 
> +		DEBUG="$(usex debug)" \
> +		BSD_KERNEL="$(usex kernel_linux)" \
> 
> since it has default values of yes/no in eutils.eclass

you probably then mean

BSD_KERNEL="$(usex !kernel_linux)"
Comment 7 Sergei Trofimovich (RETIRED) gentoo-dev 2016-08-27 14:57:32 UTC
*** Bug 369315 has been marked as a duplicate of this bug. ***