Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 423069 - app-emulation/simh-3.9.0: ebuild does not install executables
Summary: app-emulation/simh-3.9.0: ebuild does not install executables
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-23 06:05 UTC by Robert Carboneau
Modified: 2012-06-24 15:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Carboneau 2012-06-23 06:05:30 UTC
A change in the logic of src_install() in the ebuild has resulted in the emulator executables not being installed.

This code in simh-3.8.1.ebuild:
        cd "${S}/BIN"
        for BINFILE in *; do
                newbin ${BINFILE} "simh-${BINFILE}"
        done

has been replaced with this in simh-3.9.0.ebuild:
        for BINFILE in BIN/* ; do
                newbin ${BINFILE} "simh-${BINFILE}"
        done

So, for example, instead of 'newbin altair "simh-altair"', we get 'newbin BIN/altair "simh-BIN/altair"'.

Reproducible: Always

Steps to Reproduce:
1. emerge =app-emulation/simh-3.9.0
Actual Results:  
During the Install phase, an error like "cp: cannot create regular file `/var/tmp/portage/app-emulation/simh-3.9.0/temp/simh-BIN/altair': No such file or directory" is printed for each emulator included in simh.

Nothing is installed aside from documentation and the VAX ROM file.

Expected Results:  
All simh emulator executables installed.

Portage 2.1.10.65 (default/linux/amd64/10.0, gcc-4.5.3, glibc-2.14.1-r3, 3.2.12-
gentoo x86_64)
=================================================================
System uname: Linux-3.2.12-gentoo-x86_64-AMD_Athlon-tm-_64_Processor_3200+-with-
gentoo-2.1
Timestamp of tree: Sat, 23 Jun 2012 05:05:01 +0000
app-shells/bash:          4.2_p20
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r2, 3.2.3
dev-util/cmake:           2.8.7-r5
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.9.8.4
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r3, 1.11.1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            4.5.3-r2
sys-devel/gcc-config:     1.6
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 3.1 (virtual/os-headers)
sys-libs/glibc:           2.14.1-r3
Repositories: gentoo java-overlay sunrise
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA PUEL"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=k8"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=k8"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles news parse-eapi-ebuild-head protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/java-overlay /var/lib/layman/sunrise"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acl amd64 apache2 apng bazaar berkdb bzip2 cairo cdda cli consolekit cracklib crypt cups cvs cxx darcs dbus dri extras fontconfig fortran gdbm gdu git gpm gtk gudev hwdb iconv ipv6 jpeg mercurial mmx modules mudflap multilib mysql ncurses nls nptl openmp pam pcre perl php png policykit pppd python rar readline session sqlite sse sse2 ssl subversion tcpd tk unicode vorbis xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Michael Weber (RETIRED) gentoo-dev 2012-06-23 19:05:39 UTC
Yeah, I forgot the $(basename .)

--- simh-3.9.0.ebuild   2012-05-19 11:52:52.000000000 +0200
+++ simh-3.9.0-r1.ebuild        2012-06-23 20:00:12.855818546 +0200
@@ -51,7 +51,7 @@
 
 src_install() {
        for BINFILE in BIN/* ; do
-               newbin ${BINFILE} "simh-${BINFILE}"
+               newbin ${BINFILE} "simh-$(basename ${BINFILE})"
        done
 
        insinto /usr/share/simh

now I get an exec stack problem ...

 * QA Notice: The following files contain writable and executable sections
 *  Files with such sections will not work properly (or at all!) on some
 *  architectures/operating systems.  A bug should be filed at
 *  http://bugs.gentoo.org/ to make sure the issue is fixed.
 *  For more information, see http://hardened.gentoo.org/gnu-stack.xml
 *  Please include the following list of files in your report:
 *  Note: Bugs should be filed for the respective maintainers
 *  of the package in question and not hardened@g.o.
 * RWX --- --- usr/bin/simh-altair
 * RWX --- --- usr/bin/simh-altairz80
 * RWX --- --- usr/bin/simh-eclipse
 * RWX --- --- usr/bin/simh-gri
 * RWX --- --- usr/bin/simh-h316
 * RWX --- --- usr/bin/simh-hp2100
 * RWX --- --- usr/bin/simh-i1401
 * RWX --- --- usr/bin/simh-i1620
 * RWX --- --- usr/bin/simh-i7094
 * RWX --- --- usr/bin/simh-ibm1130
 * RWX --- --- usr/bin/simh-id16
 * RWX --- --- usr/bin/simh-id32
 * RWX --- --- usr/bin/simh-lgp
 * RWX --- --- usr/bin/simh-nova
 * RWX --- --- usr/bin/simh-pdp1
 * RWX --- --- usr/bin/simh-pdp10
 * RWX --- --- usr/bin/simh-pdp11
 * RWX --- --- usr/bin/simh-pdp15
 * RWX --- --- usr/bin/simh-pdp4
 * RWX --- --- usr/bin/simh-pdp7
 * RWX --- --- usr/bin/simh-pdp8
 * RWX --- --- usr/bin/simh-pdp9
 * RWX --- --- usr/bin/simh-s3
 * RWX --- --- usr/bin/simh-sds
 * RWX --- --- usr/bin/simh-swtp6800mp-a
 * RWX --- --- usr/bin/simh-swtp6800mp-a2
 * RWX --- --- usr/bin/simh-vax
 * RWX --- --- usr/bin/simh-vax780
Comment 2 Alex Buell 2012-06-24 12:01:27 UTC
That's fine, I've just tested it and it works OK. 

FWIW, I was the one who asked for 3.9.0 to be added to the tree but my ebuild did work OK, don't know why the ebuild was changed when it went into the tree.
Comment 3 Michael Weber (RETIRED) gentoo-dev 2012-06-24 15:45:28 UTC
Hello Alex,

please see bug 416173 comment 7 for the reasons I've modified the ebuild.

I made an mistake, but I had some (imho good) reasons to.

Michael