Created attachment 315805 [details] ebuild, manifest and related files Hello! I want to contribute an ebuild for git version of Notion (Ion3 fork), a tiling window manager. I'm not a developer of this project but i think they'll be okay with that. So... a few words about. Notion was forked soon after Tuomo (original author) said his final goodbye (in very special words) to opensource society and as far as i know the only actively developing fork for now. I know a lot of people who use it (including myself) and i think this is a good reason to add this ebuild to gentoo repository. Official site: http://notion.sourceforge.net P.S. Maybe it's not the smartest idea to commit only git version. If it's wrong with you guys, let me know -- i'll add the latest release along with git. Also i don't find any guides about creating metadata -- should i create it by myself or gentoo developers doing that? P.P.S. As far as i can see there is only one 'Attach file' dialogue, so i attached all files in tarball.
Hello Hobbit, thank you for your contribution, I'll pick up this request/package and will be the Gentoo maintainer for this package. The metadata.xml (maintainer part) will be created by myself, the rest (local use flags, upstream tags, ...) can be found at [1]. I'm fine with live ebuilds, but esp. patches and configure parameters tend to break upon updates, resulting in user disappointment. I suggest adding snapshots (either tagged upstream versions or known-to-be-working states) from time to time. Regarding your involvement, if you're familiar with this package and already track the development flow, I'd suggest you being a proxied maintainer [2] for this package. You'll get assigned on new bug reports (i.e. get the report as soon as it arrives) and can respond to it and prepare updates. You'll be supported by the proxy-maintainers herd (containing myself). Leave me a note if your interested. Michael [1] http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=4 [2] http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml
Some comments after reviewing your ebuild, === style/conventions === -Please keep the order/newlines of DESCRIPTION/HOMEPAGE/SRC_URI(removed)/blank line/LICENSE/SLOT/KEYWORDS/IUSE. -Please use tabs for indentation (no spaces) -LiveVCS ebuilds don't get keywords. -sed should be used with `|| die`, to abort iff the file is not found. -no need for ${S}, parent work directory of src_{prepare,configure,compile,test,install} is ${S} (${WORKDIR} for src_unpack) -sed "-g -O2" did not match (first breakage ;-)) -`use ... || sed` changed to `if ! use ... ; then sed ... || die ; fi` for above `|| die` readson. `use ... || { sed ... || die ; }` would work to, `use ... ||( sed ... || die ; )` wouldn't because of ( ... ) being a subshell. -replaced the sed on DEFINES with export DEFINES -replaced the sed on CFLAGS/LDFLAGS with s:=:+=:, CFLAGS/LDFLAGS get exported in the environment. -stripped the -Wl,--as-needed (although it's default in the profiles LDFLAGS) -changes CC=gcc to CC?=gcc in system.mk (and tc-export CC from toolchain-funcs.eclass in src_prepare) -removed the sed on install dirs, they're propertly handled in src_install. -removed src_compile, the default implementation works. === functionality === As far as I've read in system.mk, the IUSE unicode (-DCF_DE_USE_XUTF8) just switches between two equally broken implementations on bsd. It does not affect unicode support on linux as described in /usr/portage/profile/use.desc. So I dropped it. sry, i've to stop here for the moment, got work to do, I'll continue later.
Please sont get comment #2 wrong, I honestly appreciated the quality of your ebuild and enjoy working on it. There is only one funtionality flaw and the rest is all coding conventions/unwritten law only to be tough to devs ;-). The system.mk changes all end up in an diff , considerable for upstream to integrate. Michael
> Regarding your involvement, if you're familiar with this package and already > track the development flow, I'd suggest you being a proxied maintainer [2] > for this package. You'll get assigned on new bug reports (i.e. get the > report as soon as it arrives) and can respond to it and prepare updates. > You'll be supported by the proxy-maintainers herd (containing myself). > > Leave me a note if your interested. Definitely i am.
Ok, final adjustments: -I had to export STRIPPROG=cat to avoid stripping and -did not find any pwm3 binary, so I removed the corresponding .desktop and Xsession files. +*notion-9999 (20 Jun 2012) + + 20 Jun 2012; Michael Weber <xmw@gentoo.org> +notion-9999.ebuild, + +files/notion, +files/notion.desktop, +metadata.xml: + Initial import based on Hobbits work (bug 422481) + I've added Hobbit as proxied maintainer. @Hobbit: You can comment specify an real name, if you like. current metadata.xml is <herd>proxy-maintainers</herd> <maintainer> <email>little_hobbit@lavabit.com</email> </maintainer> <maintainer> <email>xmw@gentoo.org</email> <name>Michael Weber</name> <description>Proxy maintainer</description> </maintainer> </pkgmetadata>
