Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 42235 - XServer refuses to set weave pattern
Summary: XServer refuses to set weave pattern
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-20 03:08 UTC by Tavis Ormandy (RETIRED)
Modified: 2004-03-17 11:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
add -br to defaultserverargs (0199_all_4.2.0-die-ugly-pattern-die-die-die.patch,346 bytes, patch)
2004-02-21 04:18 UTC, Tavis Ormandy (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tavis Ormandy (RETIRED) gentoo-dev 2004-02-20 03:08:03 UTC
It looks like the gentoo xfree installation is configured to display a solid black root window instead of the default chequerboard-type pattern, no problem..but i quite like the "root weave" pattern and would like the option to turn it on.

Why is the option hacked out, instead of setting the option -br in startx's defaultserverargs? It seems an option that at least one person (me!) found useful has been disabled! 

Can we remove the patch, and just add this option to startx instead?

from man Xserver:

       -br     sets  the  default  root  window  to solid black instead of the
               standard root weave pattern.

I believe the patch to blame is "0199_all_4.2.0-die-ugly-pattern-die-die-die.patch"

how about substituting it with something like

-defaultserverargs="-nolisten tcp"
+defaultserverargs="-nolisten tcp -br"

in xc/programs/xinit/startx.cpp
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2004-02-20 13:32:09 UTC
It would be helpful if you would post a patch to do so. We already have one patch to the startx.cpp or whatever it is, you can get the proper location from there.
Comment 2 Tavis Ormandy (RETIRED) gentoo-dev 2004-02-21 04:18:14 UTC
Created attachment 26041 [details, diff]
add -br to defaultserverargs

Instead of hacking out the weave pattern, turn it off with -br argument.
Comment 3 Tavis Ormandy (RETIRED) gentoo-dev 2004-02-21 10:53:13 UTC
Attached patch replaces the current die-die-die patch, does exactly the same thing but without hacking out any options.

note that -br is a documented option in Xserver(1), the previous patch meant it didnt do anything.
Comment 4 Caleb Tennis (RETIRED) gentoo-dev 2004-03-10 07:54:42 UTC
*** Bug 44252 has been marked as a duplicate of this bug. ***
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2004-03-17 11:34:13 UTC
Fixed in 4.3.0-r6.