Created attachment 315505 [details, diff] Patch against app-emulation/qemu-kvm-1.0.1-r1 that implements FreeBSD support app-emulation/qemu-kvm-1.0.1-r1 currently does not work on Gentoo FreeBSD. I have attached a patch that addresses that. I am also using the following patch in epatch_user to enable the package to build: https://github.com/freebsd/freebsd-ports/blob/master/emulators/qemu-devel/files/patch-os-posix.c I tested this using the Minix test image from the QEMU website and it seemed to work: http://wiki.qemu.org/Testing
can you attach a build.log with failure?
x86-fbsd or amd64-fbsd ?
Created attachment 315545 [details] app-emulation/qemu-kvm-1.0.1-r1 build failure with patched ebuild, but no os-posix.c patch (In reply to comment #1) > can you attach a build.log with failure? Attached. (In reply to comment #2) > x86-fbsd or amd64-fbsd ? amd64-fbsd, but both should work. Someone with a x86-fbsd system would need to test it first.
(In reply to comment #2) > x86-fbsd or amd64-fbsd ? naota verified in IRC that this works on x86-fbsd too.
Have you actually tested --enable-bsd-user? I believe you aren't truly understanding what this does. qemu can emulate a userspace program like WINE does for a Windows program or it can emulate an entire system. --enable-bsd-user enables the BSD userland emulation. You don't need a BSD kernel to use this feature. You do however need some extra libraries and files to be present on your system which I don't see installed or pulled in so I'll assume that the change was incorrect. The same goes for --enable-darwin-user.
Additionally, the conditional include of util-linux is fine but the fact that we're removing UUID support necessarily is not OK. There must be a UUID library in the Gentoo/FreeBSD userland that we can use. Please figure this out.
Committed to the tree. Looked at my FreeBSD ports install of qemu and noticed they don't disable UUID so this is something that still needs to be addressed.
Clean up the amd64-gfbsd profile to not throw this out: DEPEND.bad 1 app-emulation/qemu-kvm/qemu-kvm-1.0.1-r1.ebuild: ~amd64-fbsd(default/bsd/fbsd/amd64/9.0) ['dev-libs/libaio', 'net-wireless/bluez', 'app-accessibility/brltty', '>=sys-apps/dtc-1.2.0', 'sys-libs/ncurses', 'media-sound/pulseaudio', 'sys-apps/iproute2', 'net-misc/bridge-utils', 'sys-libs/zlib[static-libs(+)]', 'sys-libs/zlib', '>=app-emulation/spice-0.9.0', '>=app-emulation/spice-protocol-0.8.1', 'sys-apps/usbredir', 'net-misc/vde', 'sys-apps/attr', 'app-emulation/xen-tools', 'app-text/texi2html'] RDEPEND.bad 1 app-emulation/qemu-kvm/qemu-kvm-1.0.1-r1.ebuild: ~amd64-fbsd(default/bsd/fbsd/amd64/9.0) ['dev-libs/libaio', 'net-wireless/bluez', 'app-accessibility/brltty', '>=sys-apps/dtc-1.2.0', 'sys-libs/ncurses', 'media-sound/pulseaudio', 'sys-apps/iproute2', 'net-misc/bridge-utils', 'sys-libs/zlib[static-libs(+)]', 'sys-libs/zlib', '>=app-emulation/spice-0.9.0', '>=app-emulation/spice-protocol-0.8.1', 'sys-apps/usbredir', 'net-misc/vde', 'sys-apps/attr', 'app-emulation/xen-tools']
Well this has sat opened for some time, I'll drop support out of the ebuilds in 30 days time if the issues aren't addressed.
(In reply to comment #9) > Well this has sat opened for some time, I'll drop support out of the ebuilds > in 30 days time if the issues aren't addressed. not sure what is left to do here, closing as needinfo in the future, please dont commit packages with broken deps if you want to avoid the mess from comment 8
(In reply to Alexis Ballier from comment #10) > (In reply to comment #9) > > Well this has sat opened for some time, I'll drop support out of the ebuilds > > in 30 days time if the issues aren't addressed. > > not sure what is left to do here, closing as needinfo > > in the future, please dont commit packages with broken deps if you want to > avoid the mess from comment 8 Or when your people ask for support that's masked so they can finish off the work they actually finish it off when they said they will.
(In reply to Doug Goldstein from comment #11) this was also directed to Richard :) you should have felt free not to commit it, or commit it without the keywords when you noticed it was broken
