>>> Unpacking xine-lib-1-rc2.tar.gz to /var/tmp/portage/xine-lib-1_rc2/work * Applying protect-CFLAGS.patch-1_rc2... * Failed Patch: protect-CFLAGS.patch-1_rc2! * * Include in your bugreport the contents of: * * /var/tmp/portage/xine-lib-1_rc2/temp/protect-CFLAGS.patch-1_rc2-8325.out Reproducible: Always Steps to Reproduce: 1. emerge xine-lib 2. 3. Actual Results: !!! ERROR: media-libs/xine-lib-1_rc2 failed. !!! Function epatch, Line 322, Exitcode 0 !!! Failed Patch: protect-CFLAGS.patch-1_rc2!
Created attachment 25919 [details] output of patch program as requested
Confirmed exact same problem here. My solution: downgrade to previous version of protect-CFLAGS.patch-1_rc2, sftp'ed from another machine. I have a request. Caleb, would you mind testing your updates in unstable before committing them to stable ? This situation is happening far too often. To me, this is at the very list a critical. Alex, could you change this ?
"at the very least", sorry about my english spelling. OK, compilation didn't go far with the downgraded patch. I don't know, but probably what the change was trying to fix. I get: /bin/sh ../../../libtool-nofpic --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -I../../.. -I../../../include -I../../../include -I../../../src -I../../../src/xine-engine -I../../../src/xine-engine -I../../../src/xine-utils -I../../../src/input -I../../../src/input `echo -Wall -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DXINE_COMPILE -Wpointer-arith -Wnested-externs -Wcast-align -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Os -march=pentium4 -fomit-frame-pointer -pipe -I/usr/kde/3.2/include/artsc -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include | sed -e 's/-fomit-frame-pointer//g'` -c -o zoom_filter_xmmx.lo `test -f 'zoom_filter_xmmx.c' || echo './'`zoom_filter_xmmx.c zoom_filter_xmmx.c:23: warning: no previous prototype for `zoom_filter_xmmx_supported' zoom_filter_xmmx.c:31: warning: no previous prototype for `zoom_filter_xmmx' zoom_filter_xmmx.c: In function `zoom_filter_xmmx': zoom_filter_xmmx.c:40: warning: unused variable `interpix' {standard input}: Assembler messages: {standard input}:83: Error: suffix or operands invalid for `add' make[4]: *** [zoom_filter_xmmx.lo] Error 1 make[4]: Leaving directory `/var/tmp/portage/xine-lib-1_rc2/work/xine-lib-1-rc2/src/post/goom' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/var/tmp/portage/xine-lib-1_rc2/work/xine-lib-1-rc2/src/post' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/var/tmp/portage/xine-lib-1_rc2/work/xine-lib-1-rc2/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/xine-lib-1_rc2/work/xine-lib-1-rc2' make: *** [all] Error 2
For the record, I do test my changes before committing them to stable, if they are going to possibly break something. My "fix" had no bearing on this bug whatsoever - the problem is that the configure script doesn't have the lines that the patch is applying. All I did was tell it the correct location of the file - something that fixed another bug. I think the solution here in the short term is to just remove the patch. It's a bad idea to patch a configure script anyway as it can get regenerated.
looks like as i was commiting the fix, mr_bones_ got to it first.
