Same part of net-misc/miredo-1.2.5 ebuild can be rework : - --disable-static shouldn't be added to econf options - prune_libtool_files can be use to delete all .la files and is more generic - --prefix=/usr is forced but also by econf - --sysconfdir=/etc is force but also by econf - emake install can be replace with einstall (so the broken --docdir) - #undef HAVE_SYS_CAPABILITY_H is written to config.h when USE caps is disable, can be fixed by a patch to autofoo stuff All this is included Reproducible: Always
Created attachment 315349 [details] miredo-1.2.5.ebuild miredo-1.2.5.ebuild
Created attachment 315351 [details, diff] files/1.2.5-BJA-configure-libcap.diff files/1.2.5-BJA-configure-libcap.diff
*** Bug 421149 has been marked as a duplicate of this bug. ***
The configure patch looks correct — but please provide a diff for the ebuild itself, as there are a few funny thing: - einstall is deprecated and shouldn't be used; - if you're using EAPI=4 you might want to just define DOCS and use `default` instead of either `emake install` or `einstall`; - the --docdir option is wrong, both because it lists ${D} (it shouldn't) and because it uses ${P} (it should use ${PF}); - --disable-static would avoid building the archive libraries for miredo that, iirc, are never used so it makes sense for it to stay. But the rest of the review is up to xmw.
Created attachment 315681 [details, diff] miredo-1.2.5.ebuild.diff Thanks for the review, here is an update (patch version this time)
Okay this was already fixed in -r1.
