As noted by another individual in https://bugzilla.xfce.org/show_bug.cgi?id=8744 , following the upgrade to xfce-base/libxfce4ui-4.10.0 the <shift> key no longer functions properly as a shortcut in XFCE4 when used in combination with another key. As an example, <shift> F2 was previously a valid keyboard shortcut for an application. Following the upgrade it no longer is. XFCE bug 8744 addresses this issue, complete with a functioning patch. Reproducible: Always Steps to Reproduce: 1. Open the XFCE keyboard settings manager (xfce4-keyboard-settings) 2. Select the "Application Shortcuts" tab 3. Add any shortcut (example "/usr/bin/xterm") and press "OK" 4. When prompted for a key combination for the shortcut press <shift> and any other key (F2 for instance) Actual Results: While the sequence was previously saved as "<shift> F2", one can clearly see that only "F2" is saved as the shortcut, omitting the <shift> key Expected Results: The shortcut should have stored "<shift> F2" I've tested the patches provided by Harald Judt "enable-shift-modifier-in-shortcut-dialog.patch" and "enable-shift-modifier-in-shortcut-grabber.patch" and can confirm they resolve this issue, with no noticeable ill affects. I assume (hope) this patch (or similar) will make it into the upstream release shortly, however it may be of benefit to other Gentoo users in the interim.
Created attachment 314361 [details] Ebuild used for testing patch The attached ebuild was used in my test of the mentioned patches.
Comment on attachment 314361 [details] Ebuild used for testing patch --- libxfce4ui-4.10.0.ebuild 2012-05-24 07:42:58.000000000 +0200 +++ - 2012-06-06 05:55:43.583417793 +0200 @@ -43,3 +43,11 @@ DOCS=( AUTHORS ChangeLog NEWS README THANKS TODO ) } + +src_unpack() { + unpack ${A} + cd "${S}" + + epatch "${FILESDIR}"/enable-shift-modifier-in-shortcut-dialog.patch + epatch "${FILESDIR}"/enable-shift-modifier-in-shortcut-grabber.patch +}
(In reply to comment #2) > Comment on attachment 314361 [details] > Ebuild used for testing patch > > --- libxfce4ui-4.10.0.ebuild 2012-05-24 07:42:58.000000000 +0200 > +++ - 2012-06-06 05:55:43.583417793 +0200 > @@ -43,3 +43,11 @@ > > DOCS=( AUTHORS ChangeLog NEWS README THANKS TODO ) > } > + > +src_unpack() { > + unpack ${A} > + cd "${S}" > + > + epatch "${FILESDIR}"/enable-shift-modifier-in-shortcut-dialog.patch > + epatch "${FILESDIR}"/enable-shift-modifier-in-shortcut-grabber.patch > +} This is outdated, and wrong style for the xfconf.eclass PATCHES=() array should be used in pkg_setup() as mentioned by the xfconf.eclass itself, and `man xfconf.eclass` after emerging eclass-manpages.
--- - 2012-06-06 13:24:22.891119407 -0400 +++ libxfce4ui-4.10.0.ebuild 2012-06-06 13:17:51.000000000 -0400 @@ -31,6 +31,11 @@ sys-devel/gettext" pkg_setup() { + PATCHES=( + "${FILESDIR}/enable-shift-modifier-in-shortcut-dialog.patch" + "${FILESDIR}/enable-shift-modifier-in-shortcut-grabber.patch" + ) + XFCONF=( $(use_enable startup-notification) $(use_enable glade gladeui)
OK. I will wait for a comment from upstream on the bug and get this merged in tree after; I really don't want to carry non-upstreamized patches in the Xfce core libs if not absolutely necessary...
looks like this has been fixed in 4.12.
