419641 – autotools.eclass: avoid type -P output for glibtoolize

Bug 419641 - autotools.eclass: avoid type -P output for glibtoolize

Summary: autotools.eclass: avoid type -P output for glibtoolize

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-06-04 18:19 UTC by Fabian Groffen
Modified:	2012-06-05 18:32 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Fabian Groffen gentoo-dev

2012-06-04 18:19:44 UTC

Please apply the following patch to autotools.eclass, or something similar to suppress the output of type -P.

Index: autotools.eclass
===================================================================
--- autotools.eclass    (revision 60957)
+++ autotools.eclass    (working copy)
@@ -276,7 +276,7 @@
 # Note the '_' prefix .. to not collide with elibtoolize() from libtool.eclass.
 _elibtoolize() {
        local LIBTOOLIZE=${LIBTOOLIZE:-libtoolize}
-       type -P glibtoolize && LIBTOOLIZE=glibtoolize
+       type -P glibtoolize > /dev/null && LIBTOOLIZE=glibtoolize
 
        [[ -f GNUmakefile.am || -f Makefile.am ]] && set -- "$@" --automake
        if [[ $1 == "--install" ]] ; then

Comment 1 SpanKY gentoo-dev

2012-06-04 21:07:13 UTC

looks fine; feel free to commit

Comment 2 Fabian Groffen gentoo-dev

2012-06-05 18:32:01 UTC

committed