Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 419631 - media-sound/gmusicbrowser 1.9.1 & 1.1.9.1_pre20120526 - need fix RDEPEND
Summary: media-sound/gmusicbrowser 1.9.1 & 1.1.9.1_pre20120526 - need fix RDEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 16:11 UTC by Sergiy Borodych
Modified: 2012-06-06 08:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
RDEPEND fix patch for 1.1.9.1_pre20120526 (depends_fix.patch,454 bytes, text/plain)
2012-06-04 16:11 UTC, Sergiy Borodych
Details
RDEPEND fix patch for 1.1.9.1_pre20120526 (depends_fix.patch,404 bytes, patch)
2012-06-04 16:18 UTC, Sergiy Borodych
Details | Diff
with suggested minimal flag (minimal.patch,873 bytes, patch)
2012-06-04 16:22 UTC, Sergiy Borodych
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergiy Borodych 2012-06-04 16:11:00 UTC
Created attachment 314209 [details]
RDEPEND fix patch for 1.1.9.1_pre20120526

Versions 1.9.1 and 1.1.9.1_pre20120526 in tree has wrong RDEPEND
Here I put patch to fix that.

There is no dependance of MP3-Tag
gmb(from v1.9.1) uses dev-perl/Gtk2-Notify instead of dev-perl/gtk2-trayicon
Comment 1 Sergiy Borodych 2012-06-04 16:16:25 UTC
Also I suggest to introduce flag like +minimal(or extra, or plugins) for ability to install minimal version of gmusicbrowser(without plugins depends)
Comment 2 Sergiy Borodych 2012-06-04 16:18:57 UTC
Created attachment 314211 [details, diff]
RDEPEND fix patch for 1.1.9.1_pre20120526

right version
Comment 3 Sergiy Borodych 2012-06-04 16:22:32 UTC
Created attachment 314213 [details, diff]
with suggested minimal flag

patch with suggested minimal flag
Comment 4 Julian Ospald 2012-06-04 22:01:32 UTC
(In reply to comment #0)
> There is no dependance of MP3-Tag

correct

> gmb(from v1.9.1) uses dev-perl/Gtk2-Notify instead of dev-perl/gtk2-trayicon

quote from NEWS:
"use Gtk2::StatusIcon instead of Gtk2::TrayIcon for the trayicon"

and that even since 1.1.8. "Gtk2::StatusIcon" is provided by dev-perl/gtk2-perl btw.

About that minimal useflag thing I am not sure, cause I don't like the fact that useflags are solely for the purpose of pulling in dependencies here (like all others do for gmusicbrowser ;/ ). That is sufficient for virtual or meta ebuilds, but for usual ebuilds it's kind of ugly, cause I might disable all useflags and all features are still available.

Another way would be to do an "elog" and name all useflag-dependant dependencies after installation, but that somehow kills the user experience in this case.
Comment 5 Julian Ospald 2012-06-05 12:57:28 UTC
+  05 Jun 2012; Julian Ospald <hasufell@gentoo.org> gmusicbrowser-1.1.8.ebuild,
+  gmusicbrowser-1.1.9.ebuild, gmusicbrowser-1.1.9.1_pre20120526.ebuild,
+  gmusicbrowser-9999.ebuild:
+  reworked dependencies, dropped all useflags wrt #419631
+

Major change to the dependency style. I dropped all useflags.

I might add a dbus useflag later, but that would just mean I swap (via sed) the default dbus-setting in gmusicbrowser.pl from on to off. It has a "-dbus" switch anyway.
Comment 6 Sergiy Borodych 2012-06-06 08:51:08 UTC
thanks for gmb support
very interesting position (about userflags)
lets see how it worked :)