Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 419629 - dev-python/xhtml2pdf-0.0.4 version bump request
Summary: dev-python/xhtml2pdf-0.0.4 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Krzysztof Pawlik (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 16:05 UTC by Ian Delaney (RETIRED)
Modified: 2012-11-05 17:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (xhtml2pdf.patch,1.36 KB, patch)
2012-06-04 16:05 UTC, Ian Delaney (RETIRED)
Details | Diff
ebuild patch (a2jmidid.patch,424 bytes, patch)
2012-06-05 14:16 UTC, Ian Delaney (RETIRED)
Details | Diff
ebuild patch (xhtml2pdf.patch,1.26 KB, patch)
2012-06-05 14:37 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (xhtml2pdf.patch,1.22 KB, patch)
2012-06-05 15:01 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2012-06-04 16:05:43 UTC
Created attachment 314207 [details, diff]
ebuild patch

Acquired a different & complete tarball.
For python 2.6 2.7

archtester xhtml2pdf # USE=doc ebuild xhtml2pdf-0.0.4.ebuild test

or

archtester xhtml2pdf # USE=doc ebuild xhtml2pdf-0.0.4.ebuild test

yield

----------------------------------------------------------------------------------
TOTAL                                                     34159  32737  12584    115    29.72%   
----------------------------------------------------------------------
Ran 35 tests in 0.111s                           OK

python2.5 doesn't work

archtester xhtml2pdf # ebuild xhtml2pdf-0.0.4.ebuild merge
on python 2.6 or 2.7 install only /usr/lib64/python2.7/site-packages/

seems the setup.py is dictating only python2.7.

There are in fact 2 test suites.  The second is in a folder testrender.  It seems it requires a version of media-gfx/imagemagick already dropped from portage so it's unusable.  Only need 1 anyway.

If ever this gets bumped, requires 
test? ( dev-python/cookbook 
which itself requires a dev-python/bunch. 
PIL is apparently == imaging.

cookbook is a package of various 'recipes', and the test for this testsuite requires a module HTLM2PDF which is such a recipe that needed be added to cookbook.         Both are sitting in improvise
Comment 1 Krzysztof Pawlik (RETIRED) gentoo-dev 2012-06-04 16:44:28 UTC
Your patch lacks in a few paces:
 - there's official tarball: http://pypi.python.org/pypi/xhtml2pdf/0.0.4
 - deps are versioned despite that there are no earlier versions
 - html5lib is duplicated (once with >=, the second time with =)
 - invalid use of src_install, you should read up on p-d-ng.eclass if you want to use it

I'll look into it later.
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2012-06-05 14:16:20 UTC
Created attachment 314313 [details, diff]
ebuild patch

frankly I don't want to use it (the eclass), the prior version comes with it and is empty of any phases to serve as a model. I did unfortunately duplicate html5lib.  If you want to stay with the pypy tarball then your call.  pypy.org tarballs have a habit of leaving out files and this is a classic example. Then the versioning cited by the alternate tarball becomes invalid anyway, and likely everything else I put in the patch. As for the install, attempting use of python_install instead from reading the eclass doesn't work anyway, resulting in a hang where the 'invalid' src_install actually installed, so that wasn't enough to clarify.  I'm sure you can straighten it out anyway, the dev that you are.
Comment 3 Mike Gilbert gentoo-dev 2012-06-05 14:27:36 UTC
Comment on attachment 314313 [details, diff]
ebuild patch

Marking irrelevant diff fragment obsolete.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2012-06-05 14:37:49 UTC
Created attachment 314315 [details, diff]
ebuild patch

ugh, I selected the wrong patch entirely.  silly. 2nd time lucky, looks right from here. sorry.
Comment 5 Mike Gilbert gentoo-dev 2012-06-05 14:46:35 UTC
Comment on attachment 314315 [details, diff]
ebuild patch

>+#python_install() {
>+#	python-distutils-ng_src_install > /dev/null
>+#	if use doc; then
>+#		docinto html
>+#		dodoc doc/*
>+#	fi
>+#	docinto "" && dodoc "README.rst"
>+#}	

Just remove the python-distutil-ng_src_install call here. You're causing the same function to call itself over and over (infinite recursion).

Also, rename python_install to python_install_all; this will run just once rather than for each python target.
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2012-06-05 15:01:44 UTC
Created attachment 314319 [details, diff]
revised ebuild patch

"Just remove the python-distutil-ng_src_install call here. You're causing the same function to call itself over and over (infinite recursion).

Also, rename python_install to python_install_all; this will run just once rather than for each python target."

ah good, thanks.  

archtester xhtml2pdf # USE=doc ebuild xhtml2pdf-0.0.4.ebuild clean install

 * Running python_install_all in /mnt/gen2/TmpDir/portage/dev-python/xhtml2pdf-0.0.4/work/chrisglass-xhtml2pdf-bf1213b/ for all
 * Installing /mnt/gen2/TmpDir/portage/dev-python/xhtml2pdf-0.0.4/temp/_pisa/pisa for single implementation (python2_7) in /usr/bin
 * Installing /mnt/gen2/TmpDir/portage/dev-python/xhtml2pdf-0.0.4/temp/_xhtml2pdf/xhtml2pdf for single implementation (python2_7) in /usr/bin


yes, perfect.  This is clearly my 1st real bump with this eclass.
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2012-11-05 17:53:06 UTC
  28 Jun 2012; Patrick Lauer <patrick@gentoo.org> +xhtml2pdf-0.0.4.ebuild: