Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 418081 - sys-boot/grub-9999 autoreconf running autopoint breaks the build
Summary: sys-boot/grub-9999 autoreconf running autopoint breaks the build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 417039
  Show dependency tree
 
Reported: 2012-05-29 03:34 UTC by Joe Kappus
Modified: 2012-09-22 02:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge info (emergeinfo.txt,5.27 KB, text/plain)
2012-05-29 03:34 UTC, Joe Kappus
Details
Build.log (build.log,3.35 KB, text/plain)
2012-05-29 03:43 UTC, Joe Kappus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Kappus 2012-05-29 03:34:31 UTC
Created attachment 313469 [details]
emerge info

>>> Preparing source in /var/tmp/portage/sys-boot/grub-9999/work/grub-9999 ...
Importing unicode...
Importing libgcrypt...
WARNING: C file isn't a module: rsa.c
WARNING: C file isn't a module: primegen.c
WARNING: C file isn't a module: elgamal.c
WARNING: C file isn't a module: ecc.c
WARNING: C file isn't a module: dsa.c
Creating Makefile.tpl...
Running autogen...
Saving timestamps...
Running autoreconf...
 * Running eautoreconf in '/var/tmp/portage/sys-boot/grub-9999/work/grub-9999' ...
 * Running aclocal -I m4 ...                                                                    [ ok ]
 * Running autopoint --force ...                                                                [ !! ]


Contents of autopoint.out:

***** autopoint *****
***** PWD: /var/tmp/portage/sys-boot/grub-9999/work/grub-9999
***** autopoint --force

autopoint: *** Missing version: please specify in configure.ac through a line 'AM_GNU_GETTEXT_VERSION(x.yy.zz)' the gettext version the package is using
autopoint: *** Stop.

Commenting out the below line in the ebuild works to get it to build, looks pretty ugly though:

   sed -i -e '/^autoreconf/s:^:set +e; e:' autogen.sh || die

I was told by phcoder of the grub project on #grub in Freenode:

May 27 17:54:13 <phcoder>       joecool: we don't autopoint

So I'm assuming the ebuild shouldn't be doing this.  Is there a way to specify to autoreconf that it should *not* autopoint?

Hopefully I wasn't followed -_-
Comment 1 Joe Kappus 2012-05-29 03:43:14 UTC
Created attachment 313471 [details]
Build.log

Because I was followed. Expecting this bug to get marked invalid anyway.
Comment 2 Mike Gilbert gentoo-dev 2012-05-29 17:26:38 UTC
@vapier:

It looks like eautoreconf does not exactly mimic the same logic that autoreconf uses with regards to detecting AM_GNU_GETTEXT_VERSION.

From what I can tell, autoreconf greps for this macro in configure.ac directly.

eautoreconf looks for it in trace output from autoconf --trace=AM_GNU_GETTEXT_VERSION.

Since grub calls AM_GNU_GETTEXT_VERSION from an auxiliary m4 file, eautoreconf is picking it up.

Can we change the autopoint detection to match autoreconf behavior? Or can you suggest an alternate solution?
Comment 3 Mike Gilbert gentoo-dev 2012-06-05 19:03:38 UTC
I have put a (possibly temporary) fix in place.

+  05 Jun 2012; Mike Gilbert <floppym@gentoo.org> grub-9999.ebuild:
+  Call autoreconf directly (via autogen.sh) since eautoreconf insists on callign
+  autopoint. Bug 418081.
+