Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 417575 - repoman should warn about "emake DESTDIR="${ED}" usage
Summary: repoman should warn about "emake DESTDIR="${ED}" usage
Status: RESOLVED OBSOLETE
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-26 08:21 UTC by Pacho Ramos
Modified: 2017-11-15 17:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2012-05-26 08:21:43 UTC
Long time ago, I was wrongly using "ED" for emake DESTDIR="${ED} install until grobian (from prefix team) kindly pointed me to:
http://www.gentoo.org/proj/en/gentoo-alt/prefix/techdocs.xml#doc_chap2

that explains:
" Usually, all but one occurrences of ${D} in an ebuild (or eclass) have to be replaced by ${ED} to work properly in the prefix. Remember that when using make DESTDIR="${D}" install the ${D} should in general not be changed, as configure was called with --prefix="${EPREFIX}"/usr."

the problem is that I have seen a lot of ebuilds wrongly using "ED" instead of "D" for this, maybe a repoman check could help to fix this

Thanks

Reproducible: Always
Comment 1 Fabian Groffen gentoo-dev 2012-05-28 07:52:57 UTC
(In reply to comment #0)
> the problem is that I have seen a lot of ebuilds wrongly using "ED" instead
> of "D" for this, maybe a repoman check could help to fix this

This is correct.  I'm affraid this can at max be a warning though, as many devs that introduce ED for make install find that that "makes things work", even though that's rarely the correct way of doing it.
Comment 2 Fabian Groffen gentoo-dev 2012-06-30 11:35:44 UTC
Would have helped to prevent recent breakage of rsync though.  On a second thought, making it fatal would make sense, just write ${D}${EPREFIX} to make clear it's on purpose
Comment 3 Fabian Groffen gentoo-dev 2017-11-15 17:42:51 UTC
This is no longer really necessary.