Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 417383 - games.eclass: please move /etc/env.d/90games to a separate package
Summary: games.eclass: please move /etc/env.d/90games to a separate package
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-24 15:30 UTC by Michał Górny
Modified: 2014-03-12 18:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
games-misc/gentoo-envd-0.ebuild (gentoo-envd-0.ebuild,1.60 KB, text/plain)
2014-01-25 18:37 UTC, Julian Ospald
Details
games.eclass.patch (games.eclass.patch,1.45 KB, patch)
2014-01-25 18:39 UTC, Julian Ospald
Details | Diff
games.eclass.patch (games.eclass.patch,1.47 KB, patch)
2014-02-02 17:16 UTC, Julian Ospald
Details | Diff
games-misc/gentoo-envd-0.ebuild (gentoo-envd-0.ebuild,1.29 KB, text/plain)
2014-02-02 17:17 UTC, Julian Ospald
Details
games-misc/gentoo-envd-0.ebuild (gentoo-envd-0.ebuild,1.30 KB, text/plain)
2014-02-02 21:55 UTC, Julian Ospald
Details
games-misc/gentoo-envd-0.ebuild (blah.ebuild,1.30 KB, text/plain)
2014-02-13 03:29 UTC, Julian Ospald
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-05-24 15:30:11 UTC
Rather than creating the unowned file in every game, please just put it in some package and RDEPEND on it. That will be much cleaner and allow for clean updates of the file contents rather than randomly rewriting it when installing games.
Comment 1 Julian Ospald 2014-01-25 18:37:33 UTC
Created attachment 368704 [details]
games-misc/gentoo-envd-0.ebuild

proposal
Comment 2 Julian Ospald 2014-01-25 18:39:34 UTC
Created attachment 368706 [details, diff]
games.eclass.patch
Comment 3 Julian Ospald 2014-02-02 17:16:53 UTC
Created attachment 369356 [details, diff]
games.eclass.patch
Comment 4 Julian Ospald 2014-02-02 17:17:07 UTC
Created attachment 369358 [details]
games-misc/gentoo-envd-0.ebuild
Comment 5 Julian Ospald 2014-02-02 21:55:29 UTC
Created attachment 369390 [details]
games-misc/gentoo-envd-0.ebuild

missed "-e" in the file check in pkg_setup
Comment 6 Julian Ospald 2014-02-13 03:29:55 UTC
Created attachment 370268 [details]
games-misc/gentoo-envd-0.ebuild

* inherit multilib.eclass explicitly

Any objections? If not, then I will fix this in ~2 weeks or so. Have been running the modified eclass for the last weeks without any issues.
Comment 7 Mr. Bones. (RETIRED) gentoo-dev 2014-02-13 03:48:02 UTC
If we're going to do this we should fix #408615 at the same time.  Am I missing how the proposed file does that or... ?

I'm also not in love with the name "gentoo-envd".  Seems like the word "game" should appear someplace.
Comment 8 Julian Ospald 2014-02-13 14:43:53 UTC
(In reply to Mr. Bones. from comment #7)
> If we're going to do this we should fix #408615 at the same time.  Am I
> missing how the proposed file does that or... ?
> 

Nope, I just linked it because solving this bug will make it easier for people to config-protect /etc/env.d/90games and add their changes which was not possible with the old eclass behavior. I am not sure if that PATH bug is actually a real issue to more than one user, but I could add the fix from #408615#c0 to the env file?

> I'm also not in love with the name "gentoo-envd".  Seems like the word
> "game" should appear someplace.

gentoo-envd -> games-envd?
Comment 9 Julian Ospald 2014-02-21 14:24:28 UTC
opinion?
Comment 10 Julian Ospald 2014-03-12 18:54:34 UTC
+*games-envd-0 (12 Mar 2014)
+
+  12 Mar 2014; Julian Ospald <hasufell@gentoo.org> +games-envd-0.ebuild,
+  +metadata.xml:
+  initial import wrt #417383

+  12 Mar 2014; Julian Ospald <hasufell@gentoo.org> games.eclass:
+  fix games.eclass to use games-misc/games-envd


let's hope I did not screw up