Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 416765 - mail-filter/pypolicyd-spf-1.0 version bump
Summary: mail-filter/pypolicyd-spf-1.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Jared B.
URL: https://launchpad.net/pypolicyd-spf/+...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-20 17:31 UTC by Michael Orlitzky
Modified: 2012-06-02 14:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mail-filter/pypolicyd-spf-1.0.ebuild (pypolicyd-spf-1.0.ebuild,773 bytes, text/plain)
2012-05-21 05:21 UTC, Jared B.
Details
mail-filter/pypolicyd-spf-1.0.ebuild (pypolicyd-spf-1.0.ebuild,778 bytes, text/plain)
2012-05-21 15:46 UTC, Jared B.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2012-05-20 17:31:53 UTC
Version 1.0 was released on 2012-03-18 and is primarily bug fixes over our current stable. There was also a license change from GPL2 to Apache2.

Changes:

--- 1.0 (2012-03-17 23:34 -0400)
  * Fixed missing authentication results headers for no authentication
    performed cases (when authres is enabled)
  * Fixed ambiguous config file warning in per user processing
  * Make functions private (leading underscore)
  * Fixed erroneous use of syslog.LOG_ERR in per user processing

--- 0.9 (2012-01-10 22:35 -0500)
  + Add support for optionally generating RFC 5451 authentication results
    headers
  + Add new Header_Type configuration option to support generating RFC 4408
    Received-SPF and/or RFC 5451 Authentication-Results headers (default is
    Received-SPF)
  ! Changed license from GPL version 2 to Apache 2.0 with agreement from all
    copyright holders
  * Log message to the error facility for all OSErrors
  * Instead of crashing if per user configuration is missing, continue with
    global configuration
  * Use openspf.net instead of openspf.org for Why text in reject/defer
    messages due to extended openspf.org downtime
  * Fix install location of standard config file when installed with distutils
  * Fix example syntax in policyd-spf.peruser.5
  * Update and clarify inconsistencies in policyd-spf.conf.5
Comment 1 Jared B. 2012-05-21 05:21:37 UTC
Created attachment 312453 [details]
mail-filter/pypolicyd-spf-1.0.ebuild

updated ebuild for 1.0.  Few notes:

* I added an authres USE flag to optionally pull in dev-python, which appears to be automatically utilized at runtime if available

* No other ebuild changes necessary

* Tested and confirmed working with postfix on an amd64 system
Comment 2 Michael Orlitzky gentoo-dev 2012-05-21 15:12:13 UTC
(In reply to comment #1)
> Created attachment 312453 [details]
> mail-filter/pypolicyd-spf-1.0.ebuild
> 
> updated ebuild for 1.0.  Few notes:
> 
> * I added an authres USE flag to optionally pull in dev-python, which
> appears to be automatically utilized at runtime if available
> 
> * No other ebuild changes necessary
> 
> * Tested and confirmed working with postfix on an amd64 system

Don't forget the license change =)

I think it might also be simpler to make authres a hard dependency:

 * Otherwise, it can fail at runtime

 * pyspf (one of our deps) requires it anyway
Comment 3 Jared B. 2012-05-21 15:46:23 UTC
Created attachment 312533 [details]
mail-filter/pypolicyd-spf-1.0.ebuild
Comment 4 Jared B. 2012-05-21 15:53:10 UTC
(In reply to comment #2)
> Don't forget the license change =)

Fixed.  Thanks for the catch.

> I think it might also be simpler to make authres a hard dependency:

Your call, though I personally think it should be optional.  It worked fine when I tested without having authres installed, and it seems to explicitly treat it as optional:

try:
    import authres
except:
    pass # authres not needed in default configuration.
Comment 5 Michael Orlitzky gentoo-dev 2012-05-21 16:02:18 UTC
(In reply to comment #4)
> (In reply to comment #2)
> > Don't forget the license change =)
> 
> Fixed.  Thanks for the catch.
> 
> > I think it might also be simpler to make authres a hard dependency:
> 
> Your call, though I personally think it should be optional.  It worked fine
> when I tested without having authres installed, and it seems to explicitly
> treat it as optional:
> 
> try:
>     import authres
> except:
>     pass # authres not needed in default configuration.

By default it's fine, but if you add,

  Header_Type = AR

to your config file, it blows up with a not-so-nice message:

  $ ./policyd-spf policyd-spf.conf < test.txt 
  Traceback (most recent call last):
    File "./policyd-spf", line 684, in <module>
      instance_dict, configData, peruser)
    File "./policyd-spf", line 462, in _spfcheck
      header += str(authres.AuthenticationResultsHeader(authserv_id = configData.get('Authserv_Id'),
  NameError: global name 'authres' is not defined
Comment 6 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-06-02 14:29:16 UTC
Bumped, thanks.