Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 41668 - ppc-sources-dev-2.4.24(-r1) compiling error
Summary: ppc-sources-dev-2.4.24(-r1) compiling error
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: PPC Porters
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-15 08:32 UTC by Maciej J. Woloszyk
Modified: 2006-02-04 06:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej J. Woloszyk 2004-02-15 08:32:49 UTC
I'm not sure if it's something with my kernel config, but when I try to
compile ppc-sources-dev on Pegasos II I've got this:
...
pmac_nvram.c: In function `pmac_nvram_init':
pmac_nvram.c:531: `pmu_nvram_read_byte' undeclared (first use in this function)
pmac_nvram.c:531: (Each undeclared identifier is reported only once
pmac_nvram.c:531: for each function it appears in.)
pmac_nvram.c:532: `pmu_nvram_write_byte' undeclared (first use in this function)
make[2]: *** [pmac_nvram.o] B??d 1
make[2]: Leaving directory `/usr/src/ppc-sources-dev-2.4.24-r1/arch/ppc/platforms'
make[1]: *** [first_rule] B??d 2
make[1]: Leaving directory `/usr/src/ppc-sources-dev-2.4.24-r1/arch/ppc/platforms'
make: *** [_dir_arch/ppc/platforms] B??d 2

I've loked int it and found that there is one #ifdef/enif missing in the
arch/ppc/platforms/pmac_nvram.c file (I'm not really sure why is it compiled
when all powermacs options are turned off). Anyway - below is the patch that
corrects this small problem.

M.

--------------------------- patch -------------------------------
--- arch/ppc/platforms/pmac_nvram.c     2004-02-15 17:21:23.000000000 +0100
+++ arch/ppc/platforms/tmp-pmac_nvram.c 2004-02-15 17:28:11.000000000 +0100
@@ -527,8 +527,10 @@
                ppc_md.nvram_read_val   = indirect_nvram_read_byte;
                ppc_md.nvram_write_val  = indirect_nvram_write_byte;
+#ifdef CONFIG_ADB_PMU
        } else if (nvram_naddrs == 0 && sys_ctrler == SYS_CTRLER_PMU) {
                nvram_naddrs = -1;
                ppc_md.nvram_read_val   = pmu_nvram_read_byte;
                ppc_md.nvram_write_val  = pmu_nvram_write_byte;
+#endif
        } else {
                printk(KERN_ERR "Don't know how to access NVRAM with %d addresses\n",
-----------------------------------------------------------------
Comment 1 David Holm (RETIRED) gentoo-dev 2004-02-15 10:37:13 UTC
Thank you for the patch, it has been commited.