Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 416177 - dev-python/pyasn1-modules-0.0.3 version bump request
Summary: dev-python/pyasn1-modules-0.0.3 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-16 00:01 UTC by Ian Delaney (RETIRED)
Modified: 2012-05-18 14:30 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (pyasn1-modules.patch,1.16 KB, patch)
2012-05-16 00:01 UTC, Ian Delaney (RETIRED)
Details | Diff
revised patch (pyasn1-modules.patch,1.15 KB, patch)
2012-05-16 12:13 UTC, Ian Delaney (RETIRED)
Details | Diff
revised patch (pyasn1-modules.patch,1.17 KB, patch)
2012-05-18 06:12 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2012-05-16 00:01:13 UTC
Created attachment 311913 [details, diff]
ebuild patch

This features two things.  
1) Also supports python3 like its counterpart dev-python/pyasn1
2) The most curious test suite I have unearthed yet and it works beautifully.  Note also it has also never been sparked up before now.

archtester pyasn1-modules # USE_PYTHON="2.5 2.6 2.7 3.1 3.2 2.7-pypy-1.8" ebuild pyasn1-modules-0.0.3.ebuild clean test merge

 * Compilation and optimization of Python modules for CPython 2.5         [ ok ]
 * Compilation and optimization of Python modules for CPython 2.6         [ ok ]
 * Compilation and optimization of Python modules for CPython 2.7         [ ok ]
 * Compilation and optimization of Python modules for CPython 3.1         [ ok ]
 * Compilation and optimization of Python modules for CPython 3.2         [ ok ]
 * Compilation and optimization of Python modules for PyPy 1.8 (Python 2.7) [ ok ]
>>> dev-python/pyasn1-modules-0.0.3 merged.

good to go.  Very good to go
Comment 1 Mike Gilbert gentoo-dev 2012-05-16 00:21:49 UTC
A few comments on your testing() function.

- Wrong amount of indentation
- Need to call popd before return
- Avoid calling chmod by invoking the shell scripts with sh
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2012-05-16 12:13:30 UTC
Created attachment 312009 [details, diff]
revised patch

ah I 'got on with it' && forgot to indent it, yes popd goes first, etc.
Comment 3 Patrick Lauer gentoo-dev 2012-05-18 04:23:12 UTC
>>> Source compiled.
 * Testing of dev-python/pyasn1-modules-0.0.3 with CPython 2.7...
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/pyasn1-modules-0.0.3/work/pyasn1-modules-0.0.3/tools/crldump.py", line 7, in <module>
    from pyasn1_modules import rfc2459, pem
ImportError: No module named pyasn1_modules
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/pyasn1-modules-0.0.3/work/pyasn1-modules-0.0.3/tools/crmfdump.py", line 5, in <module>
    from pyasn1_modules import rfc2511, pem
ImportError: No module named pyasn1_modules
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/pyasn1-modules-0.0.3/work/pyasn1-modules-0.0.3/tools/ocspreqdump.py", line 7, in <module>
    from pyasn1_modules import rfc2560, pem
ImportError: No module named pyasn1_modules
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/pyasn1-modules-0.0.3/work/pyasn1-modules-0.0.3/tools/ocsprspdump.py", line 7, in <module>
    from pyasn1_modules import rfc2560, pem
ImportError: No module named pyasn1_modules
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/pyasn1-modules-0.0.3/work/pyasn1-modules-0.0.3/tools/pkcs10dump.py", line 7, in <module>
    from pyasn1_modules import rfc2314, pem
ImportError: No module named pyasn1_modules
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/pyasn1-modules-0.0.3/work/pyasn1-modules-0.0.3/tools/pkcs1dump.py", line 7, in <module>
    from pyasn1_modules import rfc2459, rfc2437, pem
ImportError: No module named pyasn1_modules
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/pyasn1-modules-0.0.3/work/pyasn1-modules-0.0.3/tools/pkcs7dump.py", line 6, in <module>
    from pyasn1_modules import rfc2315, pem
ImportError: No module named pyasn1_modules
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/pyasn1-modules-0.0.3/work/pyasn1-modules-0.0.3/tools/pkcs8dump.py", line 7, in <module>
    from pyasn1_modules import rfc5208, pem
ImportError: No module named pyasn1_modules
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/pyasn1-modules-0.0.3/work/pyasn1-modules-0.0.3/tools/x509dump.py", line 7, in <module>
    from pyasn1_modules import rfc2459, pem
ImportError: No module named pyasn1_modules
 * ERROR: dev-python/pyasn1-modules-0.0.3 failed (test phase):
 *   Testing failed with CPython 2.7 in testing() function
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2012-05-18 06:12:07 UTC
Created attachment 312163 [details, diff]
revised patch

hmm it was drawing from already installed modules.  PYTHONPATH needed setting.
Unmerged, reset, re-tested, works beatuifully again.
Comment 5 Mike Gilbert gentoo-dev 2012-05-18 14:30:55 UTC
I tweaked it a bit and committed it. Thanks.