@amd64 @arm: Please test and add your keywords to dev-lang/go-1.0.1. @amd64: If you look on bug #342505, you will see that several of the users who were working with me on this ebuild are amd64 users; I don't know if that will speed up keywording for you, but I thought I would let you know.
Adding arch's since I couldn't when I opened the bug.
Tested on amd64, works fine.
Added ~amd64 keyword after working with floppym@gentoo.org to verify that it works there and fixing the tests.
Created attachment 316841 [details] dev-lang:go-1.0.1:20120530-184757.log fails to build on arm: * Repository: gentoo * Maintainer: williamh@gentoo.org * USE: arm elibc_glibc kernel_linux test userland_GNU * FEATURES: sandbox test userpriv usersandbox pkg/go/build cmd/go This program can only be run on EABI kernels * ERROR: dev-lang/go-1.0.1 failed (compile phase): * build failed * * Call stack: * ebuild.sh, line 85: Called src_compile * environment, line 2015: Called die * The specific snippet of code: * ./make.bash $opts || die "build failed";
It looks like there is a known issue on ARM. Can you give me some details about what I can do in the ebuild for this, or should we close this bug and wait for upstream to fix the issue? Thanks, William
Builds and works on ARMv7 (Tested on a Sabre SD mx6 based board here) Could be that it's failing on an armv5 or older.
According to upstream, go is supposed to run on arm5 boards as well. There is an environment variable I can set to inform the build system that we are building on an arm5. So, is there a way I can detect which arm processor we are building for?
(In reply to comment #7) > According to upstream, go is supposed to run on arm5 boards as well. > There is an environment variable I can set to inform the build > system that we are building on an arm5. So, is there a way I can detect > which arm processor we are building for? have a look at gcc-compiler-configure function in toolchain.eclass. I think checking CTARGET for armv5* should do it.
@maekke: I have added the CTARGET variable to the ebuilds as well as a test to determine if we are building on arm5. Can you please attempt to emerge go-1.0.2 again?
@maekke: What is your status on this? Can you please attempt to emerge go-1.0.2 again and add the ~arm keyword if it builds successfully on arm5 now?
Created attachment 322721 [details] dev-lang:go-1.0.2:20120901-113640.log (In reply to comment #10) > @maekke: > What is your status on this? Can you please attempt to emerge go-1.0.2 > again and add the ~arm keyword if it builds successfully on arm5 William, sorry for the delay - I've been busy and my arm5 box was broken =) arm5 detection misses a 'v': --- go-1.0.2.ebuild.orig 2012-09-01 13:33:52.000000000 +0200 +++ go-1.0.2.ebuild 2012-09-01 13:34:06.000000000 +0200 @@ -54,7 +54,7 @@ export GOROOT_FINAL=/usr/lib/go export GOROOT="$(pwd)" export GOBIN="${GOROOT}/bin" - if [[ $CTARGET = arm5* ]] + if [[ $CTARGET = armv5* ]] then export GOARM=5 fi can I commit this fix or are you going to do that? building is fine, tests fail, see attached log.
(In reply to comment #11) > (In reply to comment #10) > arm5 detection misses a 'v': > > can I commit this fix or are you going to do that? This has been committed. Go ahead and add your keyword. Then we can close this bug. > building is fine, tests fail, see attached log. Let's open a separate bug for the tests; I need to know if they still fail in the live ebuild or if it is just 1.0.2 that fails. Thanks, William
~arm keyword (finally) added.
I am closing this since the keyword has been added and since we have another bug for failed tests on arm5.
