Bug 415941 – net-analyzer/zabbix - install zabbix-agentd instead of zabbix-agentd-r1

• Status: RESOLVED NEEDINFO
• Product: Gentoo Linux

[Description Vadim Kuznetsov (RETIRED) 2012-05-14 14:18:58 UTC]

What is the point of name change zabbix-agentd-r1 service scripts?
Now all agents disappeared from default runlevel.


iff --git a/zabbix-1.8.13.ebuild b/zabbix-1.8.13.ebuild
index d3ab17d..59a51a3 100644
--- a/zabbix-1.8.13.ebuild
+++ b/zabbix-1.8.13.ebuild
@@ -290,8 +290,8 @@ src_install() {
                doins \
                        "${FILESDIR}/1.6.6"/zabbix_agent.conf \
                        "${FILESDIR}/1.6.6"/zabbix_agentd.conf
-               doinitd \
-                       "${FILESDIR}/1.6.6"/init.d/zabbix-agentd-r1
+               newinitd \
+                       "${FILESDIR}/1.6.6"/init.d/zabbix-agentd-r1 zabbix-agentd
                dosbin \
                        src/zabbix_agent/zabbix_agent \
                        src/zabbix_agent/zabbix_agentd

Thanks.

[Comment 1 Matthew Marlowe (RETIRED) 2012-05-15 22:23:57 UTC]

The init script update was a non-maintainer update made without prior approval, however I was notified via email after the commit.  Looking at it, I did not see anything obviously incorrect and the changelog had the following contents:

  11 May 2012; Peter Volkov <[e-mail]>
  +files/1.6.6/init.d/zabbix-agentd-r1, +zabbix-1.8.12-r1.ebuild:
  Fix problem with agentd service startup in openvz/vserver environment:
  processes inside containers are visible from host, and this precludes start
  of agentd as start-stop-daemon conciders agentd running.

I requested that the commiter open up bugs for issues in the future, and give me at least a few days to review/respond.

Commit was made only to the latest non-stable ebuild in the 1.8.x release set.  If it is causing issues, I'm guessing the right response will be to revert it and then have the original requestor open up a proper bug and have the fix more thoroughly reviewed.

[Comment 2 Matthew Marlowe (RETIRED) 2012-05-15 22:25:13 UTC]

Adding Peter Volkov <[e-mail]> to CC list so he can respond to questions concerning the init script commit.

[Comment 3 Matthew Marlowe (RETIRED) 2012-05-15 23:03:20 UTC]

+*zabbix-1.8.13-r1 (15 May 2012)
+
+  15 May 2012; Matthew Marlowe <[e-mail]> -zabbix-1.8.12-r1.ebuild,
+  +zabbix-1.8.13-r1.ebuild:
+  Revert non-maintainer commit relating to agentd init script. Bug 415941.
+

[Comment 4 Vadim Kuznetsov (RETIRED) 2012-05-16 13:27:12 UTC]

(In reply to comment #3)
> +*zabbix-1.8.13-r1 (15 May 2012)
> +
> +  15 May 2012; Matthew Marlowe <[e-mail]> -zabbix-1.8.12-r1.ebuild,
> +  +zabbix-1.8.13-r1.ebuild:
> +  Revert non-maintainer commit relating to agentd init script. Bug 415941.
> +

Peter fixed valid bug. You can add LXC environment to the list. I only complained about "-r1" in service name.
I have filed similar bug 412241 about apache service with explanation of what's going on. Thanks.

[Comment 5 Pacho Ramos 2019-12-13 15:44:46 UTC]

what is pending here?