Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 415897 - new depends for virtual/init on prefix
Summary: new depends for virtual/init on prefix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-14 10:16 UTC by Benda Xu
Modified: 2012-05-16 15:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
init.patch (init.patch,568 bytes, patch)
2012-05-15 02:31 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2012-05-14 10:16:23 UTC
init is started by host system on Prefix, so how about a new dependence like this? (mimics virtual/libc)

--- init-0.ebuild.old   2012-05-12 13:31:53.000000000 +0900
+++ init-0.ebuild       2012-05-14 19:10:22.000000000 +0900
@@ -11,6 +11,6 @@ SLOT="0"
 KEYWORDS="alpha amd64 arm hppa ia64 m68k ~mips ppc ppc64 s390 sh sparc x86 ~amd64-fbsd ~sparc-fbsd ~x86-fbsd ~amd64-linux ~x86-linux"
 IUSE=""
 
-RDEPEND="kernel_linux? ( || ( >=sys-apps/sysvinit-2.86-r6 sys-process/runit ) )
-       kernel_FreeBSD? ( sys-freebsd/freebsd-sbin )"
+RDEPEND="!prefix? ( kernel_linux? ( || ( >=sys-apps/sysvinit-2.86-r6 sys-process/runit ) )
+               kernel_FreeBSD? ( sys-freebsd/freebsd-sbin ) )"
 DEPEND=""


Reproducible: Always
Comment 1 SpanKY gentoo-dev 2012-05-14 17:09:06 UTC
do not post patches as comments as they get mangled.  i cannot understand what your patch is doing here.

attach them instead
Comment 2 Benda Xu gentoo-dev 2012-05-15 02:31:57 UTC
Created attachment 311805 [details, diff]
init.patch

the DEP patch
Comment 3 SpanKY gentoo-dev 2012-05-15 03:21:06 UTC
Comment on attachment 311805 [details, diff]
init.patch

idea is fine, but you need to unwrap it:
RDEPEND="!prefix? (
    kernel_linux? ( ... )
    kernel_FreeBSD? ( ... )
    )"
Comment 4 Benda Xu gentoo-dev 2012-05-16 07:42:27 UTC
Done. Thanks, vapier.
Comment 5 William Hubbs gentoo-dev 2012-05-16 15:43:59 UTC
It isn't clear to me why virtual/init needs to be installed in a prefix
environment at all since the way you set up the dependencies it doesn't
bring in anything.

If packages are depending on virtual/init, wouldn't it be better to have
them do something like:

!prefix? ( virtual/init )

Thanks,

William
Comment 6 SpanKY gentoo-dev 2012-05-16 15:58:31 UTC
if every depend point is going to be changed to prefix?(virtual/init), it's simpler to update the destination so that random developers in the tree need not care about USE=prefix in their own ebuilds.