Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 415299 - media-libs/taglib: tests don't run
Summary: media-libs/taglib: tests don't run
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-09 20:05 UTC by Matt Turner
Modified: 2012-05-15 18:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2012-05-09 20:05:25 UTC
FEATURES=test emerge taglib results in

>>> Working in BUILD_DIR: "/var/tmp/portage/media-libs/taglib-1.7.1/work/taglib-1.7.1_build"
No tests found. Skipping.

which is especially disappointing after I went to the trouble to keyword cppunit on mips.

Please fix.
Comment 1 Chris Reffett (RETIRED) gentoo-dev Security 2012-05-09 20:35:31 UTC
Looking at the root CMakeLists.txt, there's a line:
OPTION(BUILD_TESTS "Build the test suite"  OFF).
So I think we need to add $(cmake-utils_use_build test tests) to mycmakeargs in src_configure().
Comment 2 Chris Reffett (RETIRED) gentoo-dev Security 2012-05-09 22:40:59 UTC
Correction on that: It should be $(cmake-utils_use_build test TESTS). That still didn't make the test phase do anything, so I looked at what was being built, and it looks like taglib is kind of unconventional in its tests, since instead of adding ctest commands to CMakeLists, it compiles a bunch of files together into an executable file at taglib-1.7.1_build/tests/test_runner. Unfortunately, this command is segfaulting (at least for me), so this is going to take more investigating before it can be included in the ebuild.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2012-05-10 17:44:27 UTC
I am also ran into a segfault running tests/test_runner, but 'pushd tests && ./test_runner' or simply 'make check' works fine for here.
Comment 4 Michael Palimaka (kensington) gentoo-dev 2012-05-15 18:30:22 UTC
This is now fixed, thanks for the report.

I have also sent a patch upstream which will allow us to use the default src_test exported by cmake-utils.

+  15 May 2012; Michael Palimaka <kensington@gentoo.org> taglib-1.7.2.ebuild:
+  Actually run tests when enabled. Fixes bug #415299 by Matt Turner
+  <mattst88@gentoo.org>.