Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 414545 - media-libs/libmediainfo installs pkgconfig file with DOS line endings
Summary: media-libs/libmediainfo installs pkgconfig file with DOS line endings
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-04 01:19 UTC by Mike Gilbert
Modified: 2012-05-04 07:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2012-05-04 01:19:48 UTC
The maintainer of dev-util/pkgconf says this is a problem.

<nenolod> pkgconf assumes native line-endings
<nenolod> every other pkg-config file i have encountered works this way too
<nenolod> so i think it's a bug in the file :P

Can we run libmediainfo.pc through edos2unix before installing it?
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2012-05-04 02:41:28 UTC
If freedesktop.org pkg-config doesn't have a problem with this, then pkgconf shouldn't either, or it's not a valid provider for the virtual/pkgconfig

With that said, yeah, it could still get changed just for consistency (but it doesn't mean the bug is done before pkgconf is fixed too)
Comment 2 William Pitcock 2012-05-04 02:59:20 UTC
i agree, fixes to handle dos line endings will be added to pkgconf, but other pkg-config implementations also assume native line endings -- including the original pkg-config which predates fd.o's implementation.
Comment 3 Mike Gilbert gentoo-dev 2012-05-04 03:01:22 UTC
(In reply to comment #1)
> If freedesktop.org pkg-config doesn't have a problem with this, then pkgconf
> shouldn't either, or it's not a valid provider for the virtual/pkgconfig

IMO, this seems like an pretty small difference. Lets not go crazy over it.
Comment 5 Jeff (JD) Horelick (RETIRED) gentoo-dev 2012-05-04 05:39:10 UTC
(In reply to comment #4)
> pkgconf fixes for this:
> 
> https://github.com/nenolod/pkgconf/commit/
> 130907d5062b2bec28e671d25a30c66efd53dc57
> https://github.com/nenolod/pkgconf/commit/
> 14901943cdfbb3614004f4c22c91261468c7b453

In the tree as 0.5.1.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2012-05-04 07:53:16 UTC
(In reply to comment #1)
> With that said, yeah, it could still get changed just for consistency (but
> it doesn't mean the bug is done before pkgconf is fixed too)

http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/libmediainfo/libmediainfo-0.7.57.ebuild?r1=1.1&r2=1.2

(Without revision bump because pkgconf was fixed too. Thanks for that.)