Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 413687 - sys-libs/glibc: alpha patches to be dropped
Summary: sys-libs/glibc: alpha patches to be dropped
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-27 02:47 UTC by Matt Turner
Modified: 2012-07-03 05:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2012-04-27 02:47:36 UTC
6020_all_alpha-fix-gcc-4.1-warnings.patch can be dropped. Commit 91d46f8a fixes it.

6023_all_alpha-glibc-2.13-statfs64.patch can be dropped. Commit fe7b738e fixes it.

6032_all_alpha-syscall-6.patch can be dropped. Commit f3ce45f3 fixes it.

It looks like we've got at least three (two from Debian) that should be upstream. I'll check on those.
Comment 1 SpanKY gentoo-dev 2012-04-27 04:12:17 UTC
i'm guessing you mean for glibc-2.16.  quite a lot of patches will be dropped for that release, so i wouldn't sweat reviewing things now ...
Comment 2 Matt Turner gentoo-dev 2012-04-27 04:27:34 UTC
Actually, 91d46f8a was committed between 2.5 and 2.6.

The other two, indeed, are for 2.16. I thought they were included in 2.15 already, so ignore those.

Shrug. If you want to keep the bug open until 2.16 comes around, that's cool, and if you want to close it, that's cool too.
Comment 3 SpanKY gentoo-dev 2012-04-27 05:03:08 UTC
i was wondering about 6020 actually ... seemed odd that it wasn't fixed already.  that was added though starting with glibc-2.10.1 by your request in bug 289642.  what's up with that ?

i think glibc will build now w/out 6018_all_alpha-glibc-2.8-cache-shape.patch, but i feel like it still should be merged ...

6022_alpha_alpha-add-fdatasync-support.patch would be really nice to sort out

i'm guessing we still need 6026_all_alpha-fix-rtld-fPIC.patch.  if so, that'd be good to push upstream.
Comment 4 Matt Turner gentoo-dev 2012-04-27 05:15:02 UTC
(In reply to comment #3)
> i was wondering about 6020 actually ... seemed odd that it wasn't fixed
> already.  that was added though starting with glibc-2.10.1 by your request
> in bug 289642.  what's up with that ?

The upstream fix is cleaner, and doesn't touch every bit of inline asm, so the patch applied and I guess I didn't look further. :P

> i think glibc will build now w/out
> 6018_all_alpha-glibc-2.8-cache-shape.patch, but i feel like it still should
> be merged ...

I don't really have any idea what this one does. Did we try sending this upstream at one point?

> 6022_alpha_alpha-add-fdatasync-support.patch would be really nice to sort out

I can't remember what happened with this, and I seem to have lost any trace of it from my email. Looks like (http://sourceware.org/ml/libc-alpha/2009-10/msg00025.html) Aurelien stopped caring when debian dropped alpha. I'll send this one out again.

> i'm guessing we still need 6026_all_alpha-fix-rtld-fPIC.patch.  if so,
> that'd be good to push upstream.

I think this might have been the one that Richard Henderson wasn't able to reproduce, so he didn't commit it?

For mips, 6610_all_glibc-r10k-workarounds.patch was committed for 2.15 as commit e349dfdb.
Comment 5 SpanKY gentoo-dev 2012-04-27 06:04:53 UTC
(In reply to comment #4)

i didn't realize debian dropped alpha.  crazy.  i guess that solidifies Gentoo as the most portable ;).

i dropped 6020 from all glibc patchsets then

i think i wrote 6018, and i vaguely recall it simply not building without this fix.  and certainly every glibc release since has built + run :).  but i guess it's on my head to figure it out.  guess i'll have to start by trying to compile glibc-2.8 :x.
Comment 6 SpanKY gentoo-dev 2012-07-03 05:36:38 UTC
i've left 6022_alpha_alpha-add-fdatasync-support.patch and dropped the rest

we can re-add the others if things fail to build/test:
 - 6018_all_alpha-glibc-2.8-cache-shape.patch
 - 6021_all_alpha-glibc-2.13-ptr-mangle.patch
 - 6026_all_alpha-fix-rtld-fPIC.patch