Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 413529 - [TRACKER] unsafe gtk-query-immodules-* usage, gnome2-utils.eclass should handle it
Summary: [TRACKER] unsafe gtk-query-immodules-* usage, gnome2-utils.eclass should hand...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: Tracker
Depends on: 413485 413495 413497 413501 413507 413509 413511 413513 413517 413519 413521 413523 413525 413527
Blocks:
  Show dependency tree
 
Reported: 2012-04-25 14:32 UTC by Fabio Erculiani (RETIRED)
Modified: 2017-01-19 18:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
RFC patch for gnome2-utils.eclass (gnome2-utils.eclass.patch,1.47 KB, patch)
2012-05-13 22:21 UTC, Naohiro Aota 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Erculiani (RETIRED) gentoo-dev 2012-04-25 14:32:22 UTC 
This is a tracker bug for in-tree ebuilds using gtk-query-immodules-* in pkg_* phases in an unsafe way.

The exit status of gtk-query-immodules-* should be always checked before overwriting critical files. Corrupting Gtk/Pango/GLib/GdkPixbuf files breaks Gtk applications instantly.

Reproducible: Always
Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-04-25 15:43:53 UTC 
Given the number of ebuilds where atomic gtk-query-immodules is needed, this should be an eclass function, probably in gnome2-utils.eclass.
Comment 2 Fabio Erculiani (RETIRED) gentoo-dev 2012-04-25 15:53:57 UTC 
Nothing against that.
Comment 3 Naohiro Aota gentoo-dev 2012-05-13 22:21:06 UTC 
Created attachment 311695 [details, diff]
RFC patch for gnome2-utils.eclass

Sample patch to add atomic gtk_query_immodules to gnome2-utils.eclass. May need some more fix. Please review.
Comment 4 Naohiro Aota gentoo-dev 2012-05-27 03:33:35 UTC 
Any comments? I'll add the function and start converting in a week.
Comment 5 Naohiro Aota gentoo-dev 2012-06-21 15:11:42 UTC 
+  21 Jun 2012; Naohiro Aota <naota@gentoo.org> gnome2-utils.eclass:
+  Add new function gnome2_query_immodules_gtk{2,3} to update immodules cache.
+  #413529
+
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2012-06-23 09:19:13 UTC 
Please wait for the comments of at least one gnome team member next time and don't forgot that any eclass modifications is subject to review on gentoo-dev as this change makes API for the future and must be treated with care.
Comment 7 Fabio Erculiani (RETIRED) gentoo-dev 2013-04-21 10:33:13 UTC 
About time!!