Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 413291 - media-sound/clementine-1.0.1-r1 does not find hidden album art in the album folder
Summary: media-sound/clementine-1.0.1-r1 does not find hidden album art in the album f...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Nikoli
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-04-23 19:40 UTC by Norman Back
Modified: 2012-10-28 18:37 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix issue (clementine-1.0.1-include-hidden-album-art.patch,619 bytes, patch)
2012-04-23 19:41 UTC, Norman Back
Details | Diff
Updated ebuild to use patch (clementine-1.0.1-r1.ebuild,3.90 KB, text/plain)
2012-04-23 19:42 UTC, Norman Back
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Norman Back 2012-04-23 19:40:22 UTC
media-sound/clementine-1.0.1-r1 does not find hidden album art in the album folder but amarok-1.4.10 does.

Reproducible: Always

Steps to Reproduce:
1. Use clementine and do a full album scan on folder that containes existsing amarok album art.
2.
3.
Actual Results:  
The album art is not visibile in clementine.

Expected Results:  
The album art is visible as per amarok.

As Clementine is intended to emulate amarok 1.4.10 I'm not sure if this is a bug or enhancement.
Comment 1 Norman Back 2012-04-23 19:41:27 UTC
Created attachment 309873 [details, diff]
Patch to fix issue
Comment 2 Norman Back 2012-04-23 19:42:04 UTC
Created attachment 309875 [details]
Updated ebuild to use patch
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2012-04-24 16:19:14 UTC
Comment on attachment 309875 [details]
Updated ebuild to use patch

--- clementine-1.0.1-r1.ebuild  2012-04-14 19:47:18.000000000 +0200
+++ -   2012-04-24 18:19:06.135445618 +0200
@@ -87,6 +87,7 @@
                sed -i -e 's:event->uuid:event->udid:' src/devices/ilister.cpp
 
        epatch "${FILESDIR}"/${P}-fresh-start.patch
+       epatch "${FILESDIR}"/${P}-include-hidden-album-art.patch
 }
 
 src_configure() {
Comment 4 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-06-02 12:30:26 UTC
This sounds like beyond scope of a distro patch. Have you contacted upstream about this? We may be able to backport an upstream patch if needed, but introducing incompatible changes doesn't sound like a good idea.
Comment 5 Norman Back 2012-06-02 20:17:01 UTC
(In reply to comment #4)
> This sounds like beyond scope of a distro patch. Have you contacted upstream
> about this? We may be able to backport an upstream patch if needed, but
> introducing incompatible changes doesn't sound like a good idea.

Clementine is intended to emulate amarok 1.4.10. As amarok-1.4.10 displays the hidden album art, I assume that clementine should also. I have not cantacted upstream. I posted here in the hope that if a distro patch was not practical, the issue would be forwarded to upstream.
Comment 6 Nikoli 2012-06-02 20:25:03 UTC
Please open upstream bug with your patch. Using non upstream patches makes maintaining package much harder, especially version bumping. Also upstream may refuse to help if you are using version with a lot non approved patches.
Comment 8 Nikoli 2012-10-28 18:37:30 UTC
clementine-1.1.0 is in portage.