When I try to load/ play musepack files, xmms-1.2.9-r2 crashes. I tried xmms-musepack-0.98/ $-0.94. I get following error message: xmms: charset.c:980: xmms_charset_recode_id3: Assertion `buf' failed. Aborted Reproducible: Always Steps to Reproduce: 1. start xmms (on xterm to see error message) 2. -> load file(s) or load directory (*.mpc) 3. Actual Results: xmms is crashing Expected Results: playing the tracks see http://forums.gentoo.org/viewtopic.php?t=134307&sid=f3eb869ac89928724065cd63d235bc3f We reemerged xmms-1.2.9-r1, and that version can play musepack files
Looks like the updated recode patch is introducing some borkage... Can you give me a .mpc file that causes the problem. Please post a link and don't post the whole file here. Also, please provide the output of running 'emerge info'. Thanks.
Yep, I've just started experiencing this problem having used it for a long time without any issues whatsoever :( I'm not sure what gave in my case, but just to confirm that I too am now experiencing the problem. Jeremy: I'll do some digging ASAP and supply you with th other stuff you requested above, if you still wish.
hmm... is this only happening with the .mpc files? The xmms_charset_recode_id3 function is in libxmms/charset.c and was updated quite a bit when we went from 1.2.9-r1 to 1.2.9-r2 (it's from rusxmms.sf.net)... the assertion is logical... here's the relevant part from the patch: +char *xmms_charset_recode_id3(char *buf, int len, int *rlen) { + iconv_t icnv; + +#ifdef _CHARSET_DEBUG + fprintf(stderr,"xmms_charset_recode_id3\n"); +#endif + + assert(buf); + if (!buf) return NULL; + I really need to know how/who is calling it, so if you could give me a .mpc which breaks this or provide good gdb output (compile xmms and musepack with '-g' in CFLAGS and 'nostrip' in FEATURES) that would help alot.
I made a patch for musepack 0.94 which hopefully solves this bug. There were severel places in the file in_mpc.c where a title string with the value NULL was returned. I will also see if i can fix it for musepack 0.98.
Created attachment 25871 [details, diff] musepack-titles-0.94.patch
I've added the patch into portage in xmms-musepack-0.94-r2 Could youplease test it out and I'll move it into stable... Thanks for the patch. Clean and simple with no memory leaks... just the way I like it... I'll leave the bug open until we get 0.98 taken care of too...
Created attachment 25926 [details, diff] xmms-musepack-0.98.patch ok, it's done. xmms-musepack 0.98 is finally usable :) Besides resolving the incompatibilities with the new recode patch i also fixed the following issues: * The plugin used to generate titles from tags only if a file was played, but not as a result of a "read extended info" operation. Now it always reads the APE tags if the appropriate option is enabled. To format the tag information, xmms' common title format is used. * Song durations were sometimes calculated wrong, because a "default" sample rate of 8000 kHz was used. BTW, the patches are from me, not from Stefan Koegl as stated in the ChangeLog.
Thanks... man that old code was unpleasant... They didn't even use strncpy() to avoid a buffer overrun... char displayed_info [512]; ... strcpy ( displayed_info, eval_tag_format ( filename, artist, album, title, year, comment, genre, track ) ); Thanks again, I'm testing now and will add if it works. --Jeremy
Out of curriosity, why was this neccessary: - gtk_widget_show ( tag_description_label2 ); - gtk_widget_show ( format_box ); +// gtk_widget_show ( tag_description_label2 ); +// gtk_widget_show ( format_box ); IO'll wait to hear back before committing...
- gtk_widget_show ( titleformat_entry ); - gtk_widget_show ( title_box ); - gtk_widget_show ( tag_description_label2 ); - gtk_widget_show ( format_box ); this is the text box where you can enter a title format in musepack's configuration dialog. mith my patch it is no longer used, as the format is taken from the value you specify in the xmms configuration: _title = xmms_get_titlestring(xmms_get_gentitle_format(), input); i could add an option to override the global title format, like in the ogg and mpeg plugins, if this is desired. but then i could really create a new project and actively continue the plugin's development, as there are so many things which don't work yet (you'd better not use the built in tag editor, just opening the dialog can corrupt your playlist). well, maybe i'll do this if i get more time.
Thanks for the patches... I wish this project was better maintained... =(
Fascinating bug! Thanks a lot to all concerned. I also wish the project were better maintained (/me lives in hope that a well devised gstreamer plugin will one day exist for this codec).
