Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 412173 - app-emulation/ski-1.3.2: handle USE flags and set conditional dependencies correctly
Summary: app-emulation/ski-1.3.2: handle USE flags and set conditional dependencies co...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: IA-64 team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-04-16 07:56 UTC by Arseny Solokha
Modified: 2012-04-17 04:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch. (ski-1.3.2-ebuild.patch,701 bytes, patch)
2012-04-16 07:57 UTC, Arseny Solokha
Details | Diff
Do not check for libgnomeui-2.0. (ski-1.3.2-no-libgnomeui.patch,454 bytes, patch)
2012-04-16 09:03 UTC, Arseny Solokha
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arseny Solokha 2012-04-16 07:56:17 UTC
This bug report actually covers two different issues, so it could be probably split into two reports.

1. OpenMotif and GTK GUIs have to be enabled via --use-, not --enable- switches. I've managed to build OpenMotif front-end w/ the following patch, but haven't actually tried to build ski w/ GTK.


2. Configure w/ GTK front-end enabled fails w/ the following message:

configure: error: Package requirements (libglade-2.0 libgnomeui-2.0 >= 1.110.0) were not met:

No package 'libgnomeui-2.0' found

So libglade and libgnomeui should also be added to the list of conditional dependencies when GTK enabled.

Reproducible: Always

Steps to Reproduce:
1. USE="gtk motif" emerge app-emulation/ski
Actual Results:  
ski emerged successfully but neither GTK nor OpenMotif GUI installed (except the file /usr/share/ski/gski.glade).

Expected Results:  
xski and gski installed

The proposed patch is the simplest thing that worked.

Please note that command-line options for configure are set "manually" rather then via use_with() because the build system (erroneously?) tries to find libgnomeui-2.0 even if --without-gtk was passed.
Comment 1 Arseny Solokha 2012-04-16 07:57:18 UTC
Created attachment 309117 [details, diff]
Proposed patch.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2012-04-16 08:17:51 UTC
+	myeconf="--without-included-ltdl "
+	use gtk && myeconf+="--with-gtk"
+	use motif && myeconf+="--with-x --with-x11"

This looks broken. If user sets USE="gtk motif" the line ends up being:
"--without-included-ltdl --with-gtk--with-x --with-x11" 
As in, missing space.

USE="gtk" certainly should not pull in libgnomeui. First, libgnomeui is obsolete and shouldn't be used. Can it be avoided entirely? If not, it should propably be USE="gnome".
Comment 3 Arseny Solokha 2012-04-16 09:03:56 UTC
Created attachment 309123 [details, diff]
Do not check for libgnomeui-2.0.

(In reply to comment #2)
> +	myeconf="--without-included-ltdl "
> +	use gtk && myeconf+="--with-gtk"
> +	use motif && myeconf+="--with-x --with-x11"
> 
> This looks broken. If user sets USE="gtk motif" the line ends up being:
> "--without-included-ltdl --with-gtk--with-x --with-x11" 
> As in, missing space.

Sure. My fault.


> USE="gtk" certainly should not pull in libgnomeui. First, libgnomeui is
> obsolete and shouldn't be used. Can it be avoided entirely? If not, it
> should propably be USE="gnome".

Tarball has been created at the beginning of 2008.

Check for libgnomeui could be easily eliminated which makes it possible to build gski. GTK front-end then builds successfully but menu entries "Configure" and "Help → About" are unusable:

(gski:7467): libglade-WARNING **: could not find signal handler 'SimShowAbout'.

(gski:7467): libglade-WARNING **: could not find signal handler 'SimBtnCmdGtk'.

(gski:7467): libglade-WARNING **: could not find signal handler 'SimComboCmdGtk'.

SinShowAbout(), SinBtnCmdGtk() and SimComboCmdGtk() are in place in ssGtk.c. I have no experience w/ Glade so cannot say right now what went wrong here.
Comment 4 Arseny Solokha 2012-04-16 09:33:06 UTC
(In reply to comment #2)
s/Sin/Sim/g

Sorry for spam.
Comment 5 SpanKY gentoo-dev 2012-04-17 04:00:14 UTC
there are no --use-xxx flags.  i guess you meant --with-xxx.

at any rate, the better thing would be to fix these configure scripts rather than hacking around them in the ebuild.  we already have to generate autotools, so might as well fix the source of the problem.