Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 412007 - media-sound/kwave-0.8.7 - segfault with media-libs/audiofile-0.3.3
Summary: media-sound/kwave-0.8.7 - segfault with media-libs/audiofile-0.3.3
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-04-14 17:10 UTC by Thomas
Modified: 2012-05-02 06:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix for namespace collision between kwave and libaudiofile-0.3.3 (kwave-fix-audiofile-0.3.3.patch,55.29 KB, patch)
2012-04-14 17:12 UTC, Thomas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas 2012-04-14 17:10:54 UTC
The root cause of that crash is a C++ class name collision between Kwave and the new libaudiofile version which now also uses C++ (both have a name called "Track").

I fixed this already in git.

Reproducible: Always

Steps to Reproduce:
1.start kwave
2.load a file that uses a file format supported by libaudiofile, e.g. *.wav
3.crashes
Comment 1 Thomas 2012-04-14 17:12:39 UTC
Created attachment 308933 [details, diff]
fix for namespace collision between kwave and libaudiofile-0.3.3
Comment 2 Johannes Huber (RETIRED) gentoo-dev 2012-04-16 10:45:00 UTC
@Thomas Thank you for the patch, but its very huge. As i can see from project page you are the upstream maintainer of the project. So i would suggest to create a bug fix release.
Comment 3 Johannes Huber (RETIRED) gentoo-dev 2012-04-27 20:38:40 UTC
(In reply to comment #2)
> @Thomas Thank you for the patch, but its very huge. As i can see from
> project page you are the upstream maintainer of the project. So i would
> suggest to create a bug fix release.

ping. Can you please provide a bug fix release?
Comment 4 Thomas 2012-04-28 19:14:24 UTC
Well, the point is that the root cause is in libaudiofile and a fix for this is already available via the audiofile git repository.

So wouldn't it be better to mask media-libs/audiofile-0.3.3 instead, or to patch audiofile? I could provide that patch as well, but that one is also ~24kB.

I am already on the way to make a new release of Kwave, including some other fixes, but this still takes some weeks and I wanted to save the effort of making an additional release in between.

So what is the problem with the patch I provided for kwave? Is it that you don't want to have a file of that size in the portage tree?
Comment 5 Thomas 2012-05-02 06:18:20 UTC
update: 
I have seen that media-libs/audiofile-0.3.4 came into portage recently - that means the problem is solved now.
Comment 6 Johannes Huber (RETIRED) gentoo-dev 2012-05-02 06:41:55 UTC
(In reply to comment #5)
> update: 
> I have seen that media-libs/audiofile-0.3.4 came into portage recently -
> that means the problem is solved now.

Thanks.