Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 41186 - net-dialup/wvdial (update)
Summary: net-dialup/wvdial (update)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Dialup Developers
URL: http://open.nit.ca/wiki/?page=WvDial1...
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks: 39854
  Show dependency tree
 
Reported: 2004-02-10 18:22 UTC by Peter Colijn
Modified: 2004-02-29 05:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed ebuild (wvdial-1.54.ebuild,781 bytes, application/octet-stream)
2004-02-10 18:23 UTC, Peter Colijn
Details
Patch for compile issues (wvdial-1.54-compile-fix.patch,684 bytes, patch)
2004-02-10 18:23 UTC, Peter Colijn
Details | Diff
Proposed ebuild. (wvdial-1.54.ebuild,805 bytes, text/plain)
2004-02-10 19:51 UTC, Peter Colijn
Details
Proposed ebuild (wvdial-1.54.ebuild,763 bytes, text/plain)
2004-02-14 01:37 UTC, Peter Colijn
Details
Patch for Makefile (wvdial-1.54-makefile.patch,31.99 KB, patch)
2004-02-14 01:37 UTC, Peter Colijn
Details | Diff
New makefile patch (wvdial-1.54-makefile.patch,960 bytes, patch)
2004-02-15 22:22 UTC, Peter Colijn
Details | Diff
New ebuild (wvdial-1.54.ebuild,1001 bytes, text/plain)
2004-02-28 21:16 UTC, Peter Colijn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Colijn 2004-02-10 18:22:49 UTC
Hi,

Here's an ebuild for the new 1.54 version of Net Integration's WvDial. This new version compiles much more easily with gcc 3.x, has support for some winmodems, and a number of bugfixes (for more information on the changes see this bug's URL).

I'm also attaching a patch to fix some small compile issues.
Comment 1 Peter Colijn 2004-02-10 18:23:28 UTC
Created attachment 25371 [details]
Proposed ebuild
Comment 2 Peter Colijn 2004-02-10 18:23:55 UTC
Created attachment 25372 [details, diff]
Patch for compile issues
Comment 3 Peter Colijn 2004-02-10 19:51:39 UTC
Created attachment 25376 [details]
Proposed ebuild.

Forgot the ppp dependency. There's a crucial one!
Comment 4 Heinrich Wendel (RETIRED) gentoo-dev 2004-02-12 12:40:04 UTC
a few notes:

- please set $S to ${WORKDIR}/${P}.0 instead of cd ${S}.0 each time
- why only -j1?
- fpic should only be appended to the libs, not to everything
- why do you unset topdir?
- why do you append -Wno-deprecated

thanks though for the ebuild. if you have a bit knowledge about wvdial, maybe you can also take a look at bug #39854
Comment 5 Peter Colijn 2004-02-14 01:37:00 UTC
Created attachment 25579 [details]
Proposed ebuild

New ebuild taking your comments into account.
Comment 6 Peter Colijn 2004-02-14 01:37:42 UTC
Created attachment 25580 [details, diff]
Patch for Makefile

New makefile patch to eliminate a few things from the ebuild.
Comment 7 Peter Colijn 2004-02-15 22:22:00 UTC
Created attachment 25701 [details, diff]
New makefile patch

Oops. That patch was totally messed up. Here's a decent one.
Comment 8 Clay Culver 2004-02-25 21:49:34 UTC
Due to a current bug in wvdial 1.53 (see bug 39854), the /etc/ppp/{pap,chap}-secrets is not properly written.  This bug is corrected in 1.54...so if possible we should try to get this ebuild tested/in portage for those that need to use the package.

I'll test this ebuild tommorow.  If I don't make a second reply you can assume all went well.  =)
Comment 9 Heinrich Wendel (RETIRED) gentoo-dev 2004-02-26 06:43:40 UTC
you don't need to "cd ${S}" at the beginning of src_compile and src_install, this is done automatically.

still the question, do we really need:

[ "${ARCH}" = "alpha" -o "${ARCH}" = "hppa" ] && append-libs -fPIC
emake -j1 || die "compile failed"

have you tested it on alpha/hppa without append-libs -fPIC and does it fail for you with -j2?
Comment 10 Luca Barbato gentoo-dev 2004-02-26 22:49:34 UTC
Aliz put wvstreams-3.74 in portage and those work just with the latest wvdial.
Changing the Severity to normal.
Comment 11 Peter Colijn 2004-02-28 20:57:23 UTC
The packager (Jim Morrison: jim@nit.ca) has tested it on hppa/alpha and claims the -fPIC thing is necessary (at least it used to be for a while). And yes, parallel builds are unreliable. Sorry I should have mentioned that
Comment 12 Peter Colijn 2004-02-28 21:16:21 UTC
Created attachment 26553 [details]
New ebuild

A few more changes based on your suggestions. It turns out the parallel build
problems were fixed for this version. (It works for -j2 and -j3 on my machine,
which is SMP.) Also added dodoc for the docs, and updated dependency info.
Comment 13 Heinrich Wendel (RETIRED) gentoo-dev 2004-02-29 05:55:50 UTC
i changed the version number to 1.54.0, so we don't need S=${S}.0, added TODO to docs and commited it :)