411853 – app-emulation/vmware-modules: implicit declaration of function 'd_alloc_root'

Bug 411853 - app-emulation/vmware-modules: implicit declaration of function 'd_alloc_root'

Summary: app-emulation/vmware-modules: implicit declaration of function 'd_alloc_root'

Status:	RESOLVED TEST-REQUEST

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	x86 Linux

Importance:	Normal normal (vote)
Assignee:	Vadim Kuznetsov (RETIRED)

URL:
Whiteboard:
Keywords:	PATCH

Duplicates (1):	417059 (view as bug list)
Depends on:
Blocks:

Reported:	2012-04-13 12:54 UTC by Arvydas Sidorenko
Modified:	2012-05-24 17:37 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch to vmblock-only (264-error-fix-implicit-declaration-of-function-d_alloc_r.patch,780 bytes, patch) 2012-04-13 12:54 UTC, Arvydas Sidorenko	Details \| Diff
238 Patch for 3.4.0 d_make_root (238-3.4.0.patch,418 bytes, patch) 2012-05-24 01:21 UTC, Andrew Dean	Details \| Diff
238 ebuild to apply 3.4.0 patch. (vmware-modules-238.5-r1.ebuild,2.08 KB, text/plain) 2012-05-24 01:22 UTC, Andrew Dean	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvydas Sidorenko 2012-04-13 12:54:43 UTC

Created attachment 308761 [details, diff]
Patch to vmblock-only

Building app-emulation/vmware-modules-264.2-r1 on sys-kernel/git-sources (v3.4-rc2) fails with `error: implicit declaration of function 'd_alloc_root'`.
From `linux-3.4-rc2/Documentation/filesystems/porting` file:
[quote]
[mandatory]
	d_alloc_root() is gone, along with a lot of bugs caused by code
misusing it.  Replacement: d_make_root(inode).  The difference is,
d_make_root() drops the reference to inode if dentry allocation fails.  
[/quote]

Ebuild diff to attached patch:


--- vmware-modules-264.2-r1.ebuild~	2012-04-13 14:45:27.599844552 +0200
+++ vmware-modules-264.2-r1.ebuild	2012-04-13 14:16:44.621887757 +0200
@@ -64,6 +64,9 @@
 	epatch "${FILESDIR}/${PV_MAJOR}-jobserver.patch"
 	epatch "${FILESDIR}/${PV_MAJOR}-netdevice.patch"
 	epatch "${FILESDIR}/${PV}-3.2.0.patch"
+	if kernel_is ge 3 4; then
+		epatch "${FILESDIR}/${PV_MAJOR}-error-fix-implicit-declaration-of-function-d_alloc_r.patch"
+	fi
 	use hardened && epatch "${FILESDIR}/hardened.patch"
 }

Comment 1 Mark R. Pariente 2012-05-22 07:39:10 UTC

Please apply, linux 3.4.0 is now ~amd64 so this breakage will affect many people.

Comment 2 Arvydas Sidorenko 2012-05-22 07:52:40 UTC

(In reply to comment #1)
> Please apply, linux 3.4.0 is now ~amd64 so this breakage will affect many
> people.

Vote on importance, might attract dev attention.

Comment 3 Martin Samek 2012-05-22 09:15:36 UTC

Thanks for a patch. Works for me.

Comment 4 Vadim Kuznetsov (RETIRED) gentoo-dev

2012-05-22 13:26:06 UTC

*** Bug 417059 has been marked as a duplicate of this bug. ***

Comment 5 Vadim Kuznetsov (RETIRED) gentoo-dev

2012-05-22 14:07:59 UTC

the patch is in the tree, please sync and test. thanks.

Comment 6 Andrew Dean 2012-05-24 01:21:47 UTC

Created attachment 312905 [details, diff]
238 Patch for 3.4.0 d_make_root

Patch for 238, derived from 264 patch.

Comment 7 Andrew Dean 2012-05-24 01:22:48 UTC

Created attachment 312907 [details]
238 ebuild to apply 3.4.0 patch.

Ebuild to apply 238-3.4.0.patch.

Comment 8 Andrew Dean 2012-05-24 01:24:01 UTC

Just added patch and ebuild for those of use stuck on x86/vmware-workstation-7.1.5/vmware-modules-238.

Comment 9 Vadim Kuznetsov (RETIRED) gentoo-dev

2012-05-24 17:37:25 UTC

(In reply to comment #8)
> Just added patch and ebuild for those of use stuck on
> x86/vmware-workstation-7.1.5/vmware-modules-238.

Your patch is in the tree. Thanks.