Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 411817 - sys-apps/portage: Fix distracting-but-harmless error message during "install" phase
Summary: sys-apps/portage: Fix distracting-but-harmless error message during "install"...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: Low minor (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2012-04-13 06:42 UTC by Greg Turner
Modified: 2012-07-08 18:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
don't generate pointless error message; do handle errors correctly (portage-2.2.01.20389-distracting-error-message.patch,934 bytes, patch)
2012-04-13 06:43 UTC, Greg Turner 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Turner 2012-04-13 06:42:32 UTC 
Surely portage developers waste many precious neurotransmitters and man-microseconds every day ignoring this error:

/usr/bin/install -c -m 644 -o root -g root -t /var/tmp/portage/sys-apps/portage-2.2.01.20389/image//usr/lib/portage/pym/. ././*.py
/usr/bin/install: cannot stat `././*.py': No such file or directory

Nothing is wrong so there is no need for an error message.

Secondly: as this make-target code walks the directories in $S/pym, only errors on the last iteration bubble up and cause a failure (perhaps this disconnect evolved around the limitation that an error always occurred on the first iteration).  At least, I'm pretty sure that's right, and also pretty sure this fixes it -- tbh I only tested the non-failing case.

Reproducible: Always

Steps to Reproduce:
1. ebuild portage-recent.ebuild install
Actual Results:  
"/usr/bin/install: cannot stat `././*.py': No such file or directory"

Expected Results:  
""

Non-beautiful, non-atrocious, patch enclosed (pending bug creation).  I promise not to be offended if you don't merge it.
Comment 1 Greg Turner 2012-04-13 06:43:45 UTC 
Created attachment 308739 [details, diff]
don't generate pointless error message; do handle errors correctly
Comment 2 Zac Medico gentoo-dev 2012-04-13 07:10:00 UTC 
Looks like the patch is supposed to apply to an older version of the prefix branch, but doesn't apply now.
Comment 3 Greg Turner 2012-04-13 07:14:49 UTC 
oh :(

sorry about that, I'll port to git if applicable (or close).
Comment 4 Greg Turner 2012-04-13 07:38:59 UTC 
Applies to 85b951b73f528a3c97156a7644d7eac16ed835c0 (prefix/HEAD) in git://git.overlays.gentoo.org/proj/portage.git... should I be looking at CVS or something?

Sorry for confusion.
Comment 5 Greg Turner 2012-04-13 07:49:32 UTC 
Should I assign to Gentoo/Alt Product?  Bugzilla shows a slightly ominous-looking confirmation dialog that I don't understand when I try :)
Comment 6 Fabian Groffen gentoo-dev 2012-04-13 10:39:36 UTC 
(In reply to comment #4)
> Applies to 85b951b73f528a3c97156a7644d7eac16ed835c0 (prefix/HEAD) in
> git://git.overlays.gentoo.org/proj/portage.git... should I be looking at CVS
> or something?
> 
> Sorry for confusion.

Nope, that is the right branch/authoritative code, thanks.
Comment 8 Fabian Groffen gentoo-dev 2012-04-27 15:57:09 UTC 
Next portage release should be more silent.  I decided to go for a different approach, since the case of no existing python files should not exist.
Comment 9 Fabian Groffen gentoo-dev 2012-07-08 18:03:18 UTC 
this is in 2.2.01.20757