Created attachment 308453 [details] Fixes a compile warning I noticed that openjpeg 1.5.0 is missing from my gentoo prefix (the highest availiable is 1.3.0). I tried copying the ebuild from non-prefix portage and it seems to work well enough to build mupdf (the only thing I have that depends on it). This is all on ~amd64-linux. There was a single compilation warning, I've attached a patch to make it go away. This warning may just be because I'm on a RedHat 5 host, so it's possibly not critical that this patch is applied for everyone. Here's some relevant bugs. Note that mupdf-1.0_rc1 is ~amd64-linux now, so as it is it won't even build at all (that's how I noticed the old openjpeg library). https://bugs.gentoo.org/show_bug.cgi?id=411373 https://bugs.gentoo.org/show_bug.cgi?id=409203
I'm sure that the Gentoo maintainer will request that you file the compile warning upstream http://code.google.com/p/openjpeg/issues/list However, there is a significant diff getween gx86 tree and prefix tree for non-linux. That will need to get resolved.
(In reply to comment #1) > I'm sure that the Gentoo maintainer will request that you file the compile > warning upstream http://code.google.com/p/openjpeg/issues/list I was going to a soon as I managed to make git-svn work so I could verify the problem is still in upstream (I suppose I could just use svn proper... but it's more fun to fix things :)). > However, there is a significant diff getween gx86 tree and prefix tree for > non-linux. That will need to get resolved. Ah, sorry, I didn't have a 1.3 ebuild in my local portage copy so I just assumed all the prefix 1.3 diffs with non-prefix 1.4 were from the update. Looking at the patches: * I don't think ${P}-Makefile.patch is necessary anymore, I checked the library created and it's called "libopenjpeg.so.1.5.0" instead of "libopenjpeg-1.5.0.so". They seem to have switched to cmake instead of just using a Makefile, that's probably why it got fixed. * I don't think ${P}-freebsd.patch is necessary anymore, as the linked patch on from FreeBSD's upstream doesn't seem to have been updated either. * I don't think ${P}-darwin.patch is necessary anymore: cmake should take care of the .so vs .dynlib issue (I think? I've never actually used it on Apple) and the header file diff is obselete because the FreeBSD patch isn't necessary anymore. I don't think the HAVE_STDBOOL_H sed is necessary. It seems to have come from bug 305333 and as that bug isn't prefix-specific and it's no longer I think that means it's obselete? Hopefully that was helpful? Unfortunately I don't have any of those platforms so I don't think I can verify any of that speculation above, sorry!
Created attachment 308481 [details, diff] Fixes lrintf warning I filed an upstream bug with a cleaner patch that's also attached here. http://code.google.com/p/openjpeg/issues/detail?id=144&thanks=144&ts=1334118044
Ok, I agree with your assessment in comment #2 - thanks for the research. Also, big thanks for participating upstream. We are now pulling openjpeg from gx86 directly.
