Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 411399 - media-sound/alsa-utils-1.0.25-r2 does not need dev-util/dialog with USE=minimal
Summary: media-sound/alsa-utils-1.0.25-r2 does not need dev-util/dialog with USE=minimal
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo ALSA team [DISABLED]
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-04-09 21:34 UTC by Hans
Modified: 2012-09-09 09:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
alsa-utils-1.0.25-r2.ebuild.diff (alsa-utils-1.0.25-r2.ebuild.diff,723 bytes, patch)
2012-04-09 21:34 UTC, Hans
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans 2012-04-09 21:34:43 UTC
Created attachment 308351 [details, diff]
alsa-utils-1.0.25-r2.ebuild.diff

Recently, a change was made in media-sound/alsa-utils to not install alsaconf with USE=minimal. As dev-util/dialog is only needed for the alsaconf script in this package, it should be hidden behind "!minimal? ( dev-util/dialog )" in the ebuild.

Also, the last ewarn in the ebuild, only displayed with USE=minimal, is not needed with this recent change to the ebuild.

The attached patch fixes both these issues. (I hope .-) )

Thanks for your work!
Comment 1 nzqr 2012-05-07 14:06:15 UTC
>As dev-util/dialog is only needed for the alsaconf script
Yep, that's true.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2012-09-09 09:10:03 UTC
incorrect as alsa-info tool also uses dialog
Comment 3 Hans 2012-09-09 09:52:31 UTC
Use of dialog for alsa-info is entirely optional.

If dialog is present, alsa-info makes automatically use of it, unless provided with --no-dialog.
It dialog is not present, alsa-info automatically does not use it, gives no error message about it, and everything I have tested still works. It just does not look as pretty. But maybe I missed something.

You have, of course, the final say about this, so I will write of this no more.
Thanks for looking into it!