In && ( sys-devel/libtool:2 <sys-devel/libtool-2.4.2), we call epunt_cxx before eautoreconf. Either epunt_cxx should patch configure.{ac,in} or it should always be called after autoconf (my inner gung-ho-child says to create some qa thingy for this -- but maybe time better spent fixing epunt_cxx to patch {ac,in}). In =sys-devel/libtool-2.4.2, epunt_cxx is already "too old" and so does nothing but generate a .rej file -- note that arguably that's an epunt_cxx bug that should be fixed, and therefore not a problem with libtool-2.4.2.ebuild. Here my inner gung-ho-child has some ideas but this is the wrong bug for them, so... judgement call to be made here in the interim One other note. tests/tagdemo /does/ contain c++! That's really gross because epunt_cxx is pretty much an all-or-nothing proposition (it always recurses and patches every configure under "foo" even if we provide a "foo" directory argument). If I'm not mistaken, this means we should do "use test || epunt_cxx". -gmt Reproducible: Always Steps to Reproduce: ebuild prepare Actual Results: not punt all of the time Expected Results: do punt some of the time
Created attachment 307887 [details, diff] epunt better in sys-devel/libtool:2 ebuilds
Created attachment 307905 [details, diff] Possible substitute patch for epunt_cxx The attached could in theory be used in lieu of epunt_cxx; however it's probably better to fix epunt_cxx to intelligently handle the new configure gobbledeygook than create patches like this (so I wouldn't use it unless I trusted myself to remember to put epunt_cxx back once it got fixed).
(In reply to comment #2) > Created attachment 307905 [details, diff] [details, diff] > Possible substitute patch for epunt_cxx > > The attached could in theory be used in lieu of epunt_cxx; however it's > probably better to fix epunt_cxx to intelligently handle the new configure > gobbledeygook than create patches like this (so I wouldn't use it unless I > trusted myself to remember to put epunt_cxx back once it got fixed). to be clear, the above only pertains to libtool-2.4.2.ebuild -- epunt_cxx is fine in libtool-2.4-r4.ebuild.
(In reply to comment #3) > (In reply to comment #2) > > Created attachment 307905 [details, diff] [details, diff] [details, diff] > > Possible substitute patch for epunt_cxx > > > > The attached could in theory be used in lieu of epunt_cxx; however it's > > probably better to fix epunt_cxx to intelligently handle the new configure > > gobbledeygook than create patches like this (so I wouldn't use it unless I > > trusted myself to remember to put epunt_cxx back once it got fixed). > > to be clear, the above only pertains to libtool-2.4.2.ebuild -- epunt_cxx is > fine in libtool-2.4-r4.ebuild. Sorry. To be even clearer: attachment 307887 [details, diff] applies to all libtool-2.4*.ebuild files including 2.4.2. Attachment 307905 [details, diff] applies only to libtool-2.4.2 and would serve as a replacement for epunt_cxx in that ebuild, after attachment 307887 [details, diff] was applied to the ebuild, i.e., by replacing "use test || epunt_cxx" with: use test || epatch "${FILESDIR}"/2.4/${PN}-${PV}-epunt_cxx.patch at the end of prepare()
It just occurred to me how old my tree is... some or all of this may already be fixed, I'll bite the bullet and sync and close/update this bug as appropriate. Sorry in advance for the noise :(
(In reply to comment #5) > It just occurred to me how old my tree is... some or all of this may already > be fixed, I'll bite the bullet and sync and close/update this bug as > appropriate. Sorry in advance for the noise :( OK, as of the latest prefix-rsync all three problems are still present: o epunt_cxx before elibtoolize defeats purpose o epunt_cxx fails against libtool 2.4.2 o epunt_cxx should not be run if test useflag set So I stand by my bug.
(In reply to comment #6) > o epunt_cxx before elibtoolize defeats purpose s/elibtoolize/eautoreconf/
the point of epunt_cxx was to work around old libtool code that would incorrectly require newer C++ compilers when the code didn't actually need it it doesn't make any sense to patch configure.{ac,in} because there's nothing to patch in those files i've drop epunt_cxx from the libtool-2.x ebuilds
