Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 410837 - ebuilds that call inherit more than once
Summary: ebuilds that call inherit more than once
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-05 06:51 UTC by zvasylvv
Modified: 2012-04-05 13:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description zvasylvv 2012-04-05 06:51:32 UTC
Next list of ebuilds have 2+ unconditional calls of inheritfunction (at same indent level). Here is example what I mean

vv@crusader /dev/shm/portage $ grep inherit app-admin/puppet/puppet-2.7.12.ebuild
inherit elisp-common
inherit xemacs-elisp-common
inherit eutils ruby-fakegem
vv@crusader /dev/shm/portage $ 

List itself

vv@crusader /dev/shm/portage $ grep -c ^inherit */*/*ebuild | grep -v ':0' | grep -v ':1' 
app-admin/puppet/puppet-2.7.12.ebuild:3
dev-perl/AnyEvent/AnyEvent-5.2.5.1.ebuild:2
dev-perl/Archive-Rar/Archive-Rar-1.9.3.ebuild:2
dev-perl/DateTime-TimeZone/DateTime-TimeZone-1.22.ebuild:2
dev-perl/DBD-mysql/DBD-mysql-4.01.7.ebuild:2
dev-perl/Email-Abstract/Email-Abstract-3.001.ebuild:2
dev-perl/Email-Address/Email-Address-1.88.9.ebuild:2
dev-perl/ImageSize/ImageSize-3.2.2.0.ebuild:2
dev-perl/IO-AIO/IO-AIO-3.3.1.ebuild:2
dev-perl/IO-AIO/IO-AIO-3.6.5.ebuild:2
dev-perl/IO-AIO/IO-AIO-3.6.ebuild:2
dev-perl/POE/POE-1.289.ebuild:2
dev-python/sqlalchemy/sqlalchemy-0.7.4.ebuild:2
dev-python/virtualenvwrapper/virtualenvwrapper-3.0.ebuild:2
net-mail/notmuch/notmuch-0.10.2-r2.ebuild:2
net-misc/npapi-sdk/npapi-sdk-9999.ebuild:2
perl-core/ExtUtils-CBuilder/ExtUtils-CBuilder-0.26.03.ebuild:2
perl-core/ExtUtils-CBuilder/ExtUtils-CBuilder-0.27.03.ebuild:2
perl-core/ExtUtils-ParseXS/ExtUtils-ParseXS-2.22.03.ebuild:2
perl-core/ExtUtils-ParseXS/ExtUtils-ParseXS-2.22.05.ebuild:2
perl-core/ExtUtils-ParseXS/ExtUtils-ParseXS-2.22.06.ebuild:2
perl-core/Module-Build/Module-Build-0.34.0201.ebuild:2
perl-core/Module-Build/Module-Build-0.36.07.ebuild:2
perl-core/Time-HiRes/Time-HiRes-1.97.19.ebuild:2
perl-core/Time-HiRes/Time-HiRes-1.97.21.ebuild:2
perl-core/Time-Local/Time-Local-1.19.01.ebuild:2
sci-libs/scikits_learn/scikits_learn-0.10.ebuild:2
sci-libs/scikits_learn/scikits_learn-0.9.ebuild:2
sys-kernel/openvz-sources/openvz-sources-2.6.18.028.095.1.ebuild:2
sys-kernel/openvz-sources/openvz-sources-2.6.18.028.099.3.ebuild:2
sys-kernel/openvz-sources/openvz-sources-2.6.32.11.1.ebuild:2
sys-kernel/openvz-sources/openvz-sources-2.6.32.49.6.ebuild:2
sys-kernel/pf-sources/pf-sources-3.0.7-r2.ebuild:2
sys-kernel/pf-sources/pf-sources-3.1.6-r2.ebuild:2
sys-kernel/pf-sources/pf-sources-3.2.1-r2.ebuild:2
sys-kernel/pf-sources/pf-sources-3.2.2.ebuild:2
sys-kernel/pf-sources/pf-sources-3.2.3.ebuild:2
sys-kernel/pf-sources/pf-sources-3.2.4.ebuild:2
sys-kernel/pf-sources/pf-sources-3.2.5.ebuild:2
sys-kernel/pf-sources/pf-sources-3.2.6.ebuild:2
sys-kernel/pf-sources/pf-sources-3.2.7.ebuild:2
sys-kernel/rt-sources/rt-sources-3.0.10_p27.ebuild:2
sys-kernel/rt-sources/rt-sources-3.0.12_p29.ebuild:2
sys-kernel/rt-sources/rt-sources-3.0.12_p30.ebuild:2
sys-kernel/rt-sources/rt-sources-3.0.14_p31.ebuild:2
sys-kernel/rt-sources/rt-sources-3.0.8_p23.ebuild:2
sys-kernel/rt-sources/rt-sources-3.0.9_p25.ebuild:2
x11-drivers/xf86-input-mtrack/xf86-input-mtrack-0.2.0.ebuild:2
vv@crusader /dev/shm/portage $ 
 

Reproducible: Always



Expected Results:  
those inherit calls should be revised and joined



Would be nice to have a check in precommit hook for ebuids to prevent this
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2012-04-05 13:12:22 UTC
Is this actually a problem?
Comment 2 Torsten Veller (RETIRED) gentoo-dev 2012-04-05 13:50:08 UTC
No, technically it's not a problem (see bug #172831).
Comment 3 zvasylvv 2012-04-05 13:56:06 UTC
(In reply to comment #1)
> Is this actually a problem?

No :) I just pointed a tiny glitch in those ebuilds (and would like to see our portage tree cleaner)
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2012-04-05 13:58:22 UTC
Thanks, Torsten.

(In reply to comment #3)
> No :) I just pointed a tiny glitch in those ebuilds (and would like to see
> our portage tree cleaner)

Apparently there is no glitch. Also, tree-cleaner@ has nothing to do with QA or PMS.